import libtiff fails about pylibtiff

[GoogleCodeExporter]

I looked into this and will try to fix it today. The problem is in the 4.0.3 
header starting with this line:

#define     CODINGMETHODS_T4_1D     (1 << 1)    /* !T.4 1D */

Since the value has spaces in it the string filtering cuts off everything after 
"(1" which isn't valid python. The proposed solution doesn't seem to work for 
me, I'm looking into it now. And unless I'm missing something the 
"eval(value,d)" shouldn't be needed since there is a "if value in d" check 
right above that.

The proposed solution fails on my machine because it doesn't remove the 
whitespace after "FAXMODE_NORTC" and then doesn't match in the dictionary. 
Still doesn't solve the TIFFTAG_COLORMAP undefined problem either.

Thanks for reporting the bug.

Original comment by [email protected] on 23 Apr 2013 at 9:08

[GoogleCodeExporter]

I have a fix to this bug (I have forgotten to commit it).
Will commit in a moment or so.

Original comment by pearu.peterson on 23 Apr 2013 at 9:25

[GoogleCodeExporter]

Thanks, I'll try it out. FYI here is my fix:

Index: libtiff/libtiff_ctypes.py
===================================================================
--- libtiff/libtiff_ctypes.py   (revision 90)
+++ libtiff/libtiff_ctypes.py   (working copy)
@@ -71,11 +71,11 @@
     d = {}
     for line in f.readlines():
         if not line.startswith('#define'): continue
-        words = line[7:].lstrip().split()[:2]
+        words = line[7:].lstrip().split(None, 1)[:2]
         if len (words)!=2: continue
         name, value = words
         i = value.find('/*')
-        if i!=-1: value = value[:i]
+        if i!=-1: value = value[:i].strip()
         if value in d:
             value = d[value]
         else:

Original comment by [email protected] on 23 Apr 2013 at 9:55

[GoogleCodeExporter]

I presume the issue is Fixed. Please open when the issue persists.

Original comment by pearu.peterson on 22 May 2013 at 7:55

• Changed state: Fixed