OldDbSNPFeature uses 0-based locations about htsjdk

[vdauwera]

I'm not aware that anyone uses this anymore, and it has been deprecated for a while. So I would recommend deleting it. If someone complains we can always necromance it back.

[nh13]

👍

[nenewell]

CountRecords.getFeatureCodec() in tribble.example returns an OldDbSNPCodec for .snp and .rod feature files. How should we handle? Just comment out the if statement as was done for VCFCodecs and SoapSNPCodecs in this method? Thank you.

[vdauwera]

Yes, please comment out those lines in the same way. Usually we'd delete rather than comment out but in this case I think it's probably good to have a conveniently accessible record of the different formats (as opposed to having it buried in the git history).

[nenewell]

Will do. From: Geraldine Van der Auwera Sent: Monday, May 11, 2015 2:49 PM To: samtools/htsjdk Cc: nenewell Subject: Re: [htsjdk] OldDbSNPFeature uses 0-based locations (#181) Yes, please comment out those lines in the same way. Usually we'd delete rather than comment out but in this case I think it's probably good to have a conveniently accessible record of the different formats (as opposed to having it buried in the git history). — Reply to this email directly or view it on GitHub.