GithubHelp home page GithubHelp logo

Comments (5)

DavidXanatos avatar DavidXanatos commented on July 30, 2024

At some point I guess a refactoring of the code would be in order, but I think that is not one of the things to be done first.

from sandboxie.

elfring avatar elfring commented on July 30, 2024

How do you think about to avoid that this software depends on undefined behaviour?

from sandboxie.

DavidXanatos avatar DavidXanatos commented on July 30, 2024

Why would you assume its relaying on undefined behavior?
From not adhering to a naming convention to undefined behavior is IMHO quite a long way.

from sandboxie.

elfring avatar elfring commented on July 30, 2024

Would you like to delete any underscores in affected identifiers?

from sandboxie.

DavidXanatos avatar DavidXanatos commented on July 30, 2024

mmh...

When I search for "typedef struct _" in the code I get almost 200 results and there the _ is followed by a Capital latter.

And this practice to typedef struct _MY_STRUCT {...} MY_STRUCT,*PMY_STRUCT; is extremely popular.

Apparently the majority of developers agreed to ignore that particular issue.

Look if that would be a few things to change that, I don't care if it makes you happy I would have done it. But its 185 struct definitions, and MSFT's own SDK's and WDK's do the exact same thing. That to me is also a standard violation by the letter, as those are imho not parts of the compiler but external frameworks.

from sandboxie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.