GithubHelp home page GithubHelp logo

Comments (3)

enielse avatar enielse commented on June 19, 2024

Cause: This is due to incorrectly dropping logL and chi2 terms corresponding to 0-count (or "zero-frequency") outcomes when these should in fact be nonzero. In the chi2 case, the general term, N(p-f)^2/p, becomes N*p. In the logL within our "poisson picture", the general term N*f*log(p) - N*p becomes -N*p. In both cases these are nonzero even if f==0.

Fix: the hotfix deployed as Release 0.9.7.4 usually fixes this issue with a temporary patch that causes DataSet-generation routines to not omit any probabilities.

from pygsti.

enielse avatar enielse commented on June 19, 2024

Update: a permanent fix that repairs the logL and chi2 functions will be merged into the main branches by pull request #64. We'll plan to close this issue once this appears in a release version of pyGSTi.

from pygsti.

enielse avatar enielse commented on June 19, 2024

As promised, closing this issue now that the version 0.98 release is out, which fixes this issue.

from pygsti.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.