Comments (5)
You're correct that we still can't accept PRs -- sorry about that!
from pygsti.
Apologies, this might just be user error/a documentation problem: I hadn't realised that gaugeopt_suite_to_dictionary
hard-codes a list of two-qubit gate names rather than inspecting the target model. In the if isinstance(gg, _objs.TrivialGaugeGroup):
branch, the optimisation is added unconditionally – that's why it is executed for the target model.
from pygsti.
(A warning if no gate in unreliableOps
is found would help make this more discoverable.)
from pygsti.
I've just added a fix for this in 15e8f45. It should avoid having 'single-2QUR' present for just the target mode ('single-2QUR' should either be there for all or none of the modes) and, as was suggested, a warning is now generated when no gate in unreliableOps
is found.
As an aside, the reason why it's difficult to perform this discovery automatically is that within PyGSTi all of the gates in a 2-qubit model are seen as 2-qubit gates, and represented by 16x16 matrices. We could test whether a gate is entangling, and choose only those gates as the default unreliableOps
in the future, but we haven't done this yet.
Finally, note that this fix is only on the beta branch, and not on master (or available via pip). Because this doesn't seem like a critical issue to fix immediately, my preference would be to just wait until our normal develop cycle produces a new release and then this fix will be included on the master branch. Please feel free to argue this point. Let's leave this issue open until the fix reaches a release.
from pygsti.
Great, thanks, this is perfect – feel free to close this whenever most convenient for you. Automatic detection probably isn't worth it, I was just taken by surprise by the fact that it did seem to auto-detect it for Target (when in actuality the entire option was just added since the last version I had used).
from pygsti.
Related Issues (20)
- Gate staticized, unitarized during gate reassignment HOT 1
- LGST doesn't work with TP-parameterized target models
- Reparameterizing model doesn't propagate to model members dictionaries HOT 2
- Cannot compute product of editable circuit
- Nondeterministic Unit Test Failures HOT 5
- Re-evaluating Skipped Unit Tests HOT 3
- OpenQASM returned by convert_to_openqasm includes opaque gates. HOT 8
- Gauge transformations on SPAM HOT 2
- Faster unit tests/notebooks HOT 9
- Unexpected file in test_packages HOT 2
- ProtocolResults Incompletely Loads From Directory
- Target & True Models Should Be Static HOT 5
- Idea: Switch macOS tests to run against beta branch HOT 4
- Pygsti is incompatible with scipy 1.12 HOT 1
- Fiducial selection for prep fiducials generates wrong qubit labels HOT 6
- Avoid unintended calls to ``ComplementPOVMEffect.to_vector()``
- Use ``@`` for matrix-matrix and matrix-vector multiplications HOT 3
- Docstring for QuditProcessorSpec has mistake for "availability"
- Distinction between correlation error generators and active error generators in HTML reports
- Performance improvement for 2-qubit GST HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pygsti.