GithubHelp home page GithubHelp logo

Comments (3)

radikz avatar radikz commented on June 2, 2024 1

Ah right. thanks for the kind response.
Closed for now. ^^

from fpdart.

radikz avatar radikz commented on June 2, 2024

I already solved it with

TaskEither<AppError, Response> _request(String url) => TaskEither<AppError, Response>.tryCatch(
        () async => await dio.get(url),
        (error, stackTrace) => AppError.from(error as Exception),
      ).chainEither(
        (response) => Either.tryCatch(
          () {
            if (response.statusCode != 200){
              Either.left(AppError.fromResponse(response));
            }
            return response;
          },
          (_, __) => AppError.fromResponse(response),
    ),
  );

I changed it from Either.fromPredicate to Either.tryCatch
I am not sure if this is best practice of fp.

from fpdart.

SandroMaglione avatar SandroMaglione commented on June 2, 2024

Hi @radikz

In your first example the issue is that _validResponseBody returns Either<E, String>, while the type on your TaskEither is TaskEither<AppError, Response> (so Response instead of String). That's because you are mapping (map) the Response to String using .map((r) => r.data);.

Your second example works because in your tryCatch you just return Response (return response;) instead of response.data.

Does this make it more clear?

from fpdart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.