Comments (3)
I'm okay with passing window into the closure if you desire, although I don't feel it necessary - I'd be interested in hearing your rationale for why you'd recommend this.
I don't believe undefined is used anywhere in the code currently, so there's no need to define it as a parameter for now; and I typically prefer to test against void(0)
myself, although that's just personal preference, as it eliminates issues with undefined (the variable so named) being potentially assigned a value other than undefined
.
from jquery-ajax-localstorage-cache.
Fair enough about undefined. I would use void 0, but it can often be unreadable for those who don't quite understand its intentions. About passing window to the closure, it's slightly faster than using implied globals, as there is less work for the interpreter to "walk the scope chain".
from jquery-ajax-localstorage-cache.
Good point - if you'd like to submit a PR, I'll review and merge it.
from jquery-ajax-localstorage-cache.
Related Issues (20)
- Integration with Infinite Scroll HOT 1
- Add seamless integration with ifModified jQuery's option
- Status code caching HOT 1
- Success function array fails: TypeError: object is not a function HOT 1
- use with done callback
- Unmaintained HOT 3
- Possible bug with a user passing an object via localCache that isn't an instance of Storage HOT 7
- Add to bower.io HOT 1
- Bug when cache is set to false and cacheKey omitted in the options HOT 2
- Pre-append ; to the start of the plugin HOT 1
- Check if options.localCache is undefined before continuing HOT 2
- 'toLowerCase' error during ajax call. HOT 4
- Optionally, do not clear cache on AJAX error HOT 2
- cacheKey sometimes generates poorly HOT 3
- Error Checking on dataType
- default cacheKey function fails HOT 2
- Build a plugin
- Doenst work with dataType XML
- unable to clone on drush make process HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-ajax-localstorage-cache.