GithubHelp home page GithubHelp logo

Comments (3)

SaneMethod avatar SaneMethod commented on August 16, 2024

I'm okay with passing window into the closure if you desire, although I don't feel it necessary - I'd be interested in hearing your rationale for why you'd recommend this.

I don't believe undefined is used anywhere in the code currently, so there's no need to define it as a parameter for now; and I typically prefer to test against void(0) myself, although that's just personal preference, as it eliminates issues with undefined (the variable so named) being potentially assigned a value other than undefined.

from jquery-ajax-localstorage-cache.

softwarespot avatar softwarespot commented on August 16, 2024

Fair enough about undefined. I would use void 0, but it can often be unreadable for those who don't quite understand its intentions. About passing window to the closure, it's slightly faster than using implied globals, as there is less work for the interpreter to "walk the scope chain".

from jquery-ajax-localstorage-cache.

SaneMethod avatar SaneMethod commented on August 16, 2024

Good point - if you'd like to submit a PR, I'll review and merge it.

from jquery-ajax-localstorage-cache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.