Comments (6)
Hmm, I think it might be worth it to scrap the regex splitting in this function. I have tested it quite a bit, but it does seem like this is a use case that breaks it. Perhaps a solution will be to run a regular .split("/")
operation, and then loop through the segments looking for instances where there is an open <
but the close >
is in the next segment, and merge.
from sanic-routing.
def _normalize(parts, delimiter):
part_iter = iter(parts)
normalized = []
for part in part_iter:
if part.startswith("<") and not part.endswith(">"):
ending = ""
try:
while not ending.endswith(">"):
ending += delimiter + next(part_iter)
except StopIteration:
raise Exception("invalid")
part += ending
normalized.append(part)
return normalized
def path_to_parts(path, delimiter="/"):
parts = _normalize(path.split(delimiter), delimiter)
return tuple([part if part.startswith("<") else quote(part) for part in parts])
I just threw together this little snippet to prove my point. I think this is probably the way to go and should be more accurate in catching corner cases like this one.
/image/iiif/<image_id>/<region:full|square|\d+,\d+,\d+,\d+>/<size:max|\d+,|,\d+|\d+,\d+>/<rotation:int>/default.jpg
('', 'image', 'iiif', '<image_id>', '<region:full|square|\\d+,\\d+,\\d+,\\d+>', '<size:max|\\d+,|,\\d+|\\d+,\\d+>', '<rotation:int>', 'default.jpg')
from sanic-routing.
Can you maybe provide a path
for which normal .split("/")
does not work? Just to have a clear understanding of the problem.
from sanic-routing.
Can you maybe provide a
path
for which normal.split("/")
does not work? Just to have a clear understanding of the problem.
@app.get(r"/path/to/<deeply_nested:[a-z/]+>/thing")
async def handler(request, deeply_nested):
return text(deeply_nested)
$ curl localhost:9999/path/to/location/with/slashes/thing
location/with/slashes
There are three use cases:
- Custom regex routes that have a
/
in them - a
<path:path>
param (which uses item 1) - static files (which uses item 2)
Given this, that is the reason for the complication with my proposed solution. Using .split()
will unintentionally break apart some of these segments, so we will need to stitch them back. I thought the regex covered all scenarios, but I think a "dumber" solution might just be simpler.
from sanic-routing.
I've looked a bit and found the solution her:
https://stackoverflow.com/questions/732029/how-to-split-string-by-unless-is-within-brackets-using-regex
Here is the pull request with extra tests
from sanic-routing.
Fixed by #40
from sanic-routing.
Related Issues (20)
- `RouteExists` thrown when registering a directory and a missing file to the same route. HOT 1
- Pattern registration auto-compile HOT 1
- Context managed code generation
- Having two or more <path> routes does not work with different methods HOT 6
- Regex params not type cast
- `404`s with parameter type `path` HOT 11
- Invalid declaration: <entity_id>:meta HOT 4
- Incorrect handling of `pattern` argument for `register_pattern` HOT 2
- Unique route names
- [Feature] Fallback route when none match HOT 2
- Colon in uri generate response 404 HOT 2
- parts_to_path, raises exception for part with multiple parameters without type hint HOT 1
- Websocket conflicts with http GET
- Unquoted URLs should be case-insensitive
- Parameter types are broken when using <something:path>
- "unquote=True" breaks int path parameters HOT 1
- Parameterized Route returns 404 instead of 405 HOT 2
- Expandable routes have more priority than static routes when adding a trailing slash to the path HOT 2
- Requirements based on equality
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sanic-routing.