Comments (2)
Hi @Shisuki sorry for taking so long in responding.
This is a perfect example of the way of doing unit testing using dependency injections (asked here #65) thanks for taking the time to write a few snippets of code to showcase it.
For what I see the problem is with the Logger you are passing to the authentication service instance, did you instantiated it first? or are you just passing the class?
Since this the authentication service was written with the dependency injection pattern, you can pass a dummy object that respects the interface of Logger but without the implementation of the methods
it('should return 201 if request is valid', async (done) => {
const aMockedLoggerInstance = {
info() {
// nothing!
}
}
const authenticationService = new AuthenticationService(
User,
aMockedLoggerInstance,
mock<EventDispatcherInterface>(),
);
// You can also instantiate it by container, it returns the same error
// const authenticationService = Container.get(AuthenticationService);
const userDTO = factory.userDTO.build();
const res = await request(server).post('/users').send(userDTO);
expect(res.status).toBe(201);
done();
});
This can be pretty useful when you test services that depend on other and you don't want to execute the code but rather just make sure it is called.
from bulletproof-nodejs.
Hey @santiq thanks for your fast reply and I'm so sorry for taking so long to come back to you..
If you see in my example above it wasn't because I didn't use a dummy object for as a logger, that works fine, but when it works on the tests the implementation on the actual route breaks, and even in the test if I use the DI-container twice it also breaks (All shown above)
Anyway I've given up on using any DI-Container months ago as it ended up making my life more difficult and in the long term everything becomes tightly coupled with the Container.
Right now I've turned to pure DI with the use of index files as interfaces for the services and then barrel files to export exactly what I need, which gives me the best of both worlds and with just moderately more code configuration.
Thank you for your time!
from bulletproof-nodejs.
Related Issues (20)
- How to implement the swagger following this structure? HOT 2
- Email client replacement HOT 1
- Implementation with Mysql/pgsql with typescript HOT 3
- examples for creating new models in mongo HOT 1
- Project structure by feature HOT 2
- add absolute imports? HOT 1
- Where do you add utility functions and constants? HOT 1
- Absolute import "Cannot find module @/*" HOT 5
- Jwt invalid algorithm HOT 2
- Recreate code to be compatible with all os development environment
- Changing a request would require changes in 3 places of the code, is there a better solution? HOT 1
- api status handling
- Better testing project structure/ configuration? HOT 1
- Using a different database for tests HOT 1
- Where store Push Notification Token?
- Refactoring Sub/Pub Layer Poll HOT 1
- Is there same or similar example in js? HOT 1
- Redis client HOT 2
- adapt for mySQL HOT 2
- Update Mongoose for Heroku Deployment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bulletproof-nodejs.