GithubHelp home page GithubHelp logo

Comments (3)

droshev avatar droshev commented on September 10, 2024

@m8524769 did you set all aria attributes needed? If so, can you create a small stackblitz example demonstrating that you cannot set this on the application side?

from fundamental-ngx.

m8524769 avatar m8524769 commented on September 10, 2024

@m8524769 did you set all aria attributes needed? If so, can you create a small stackblitz example demonstrating that you cannot set this on the application side?

Hi @droshev, thanks for your reply, it could be reproduced in the latest documentation and I don't think we should set aria attributes on the application side.

from fundamental-ngx.

mikerodonnell89 avatar mikerodonnell89 commented on September 10, 2024

@m8524769 Because the <fd-form-input-message-group> component (like from the link you provided) is agnostic to whatever is placed inside of it via ng-content, we advise that you should handle aria attributes on the application side. If we were to set these attribrutes on the fd-form-message internally in the library to force an announcement, it would potentially override or interrupt whatever the screenreader had originally planned to say, possibly set by the application. So unfortunately it is best to handle this application side, like you see in the examples here: https://sap.github.io/fundamental-ngx/#/core/form-message

However, our documentation in the link you provided should be utilizing aria-describedby so I'll be updating that

from fundamental-ngx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.