GithubHelp home page GithubHelp logo

Comments (5)

droshev avatar droshev commented on September 10, 2024 1

@InnaAtanasova We need to check the design for the floating footer again. It looks like that i was changed.
Our floating bar is always displayed on the bottom of the page(with an absolute position) example - https://stackblitz.com/edit/1hqnwx

from fundamental-ngx.

InnaAtanasova avatar InnaAtanasova commented on September 10, 2024 1

I also opened a PR that adds an input property to Dynamic Page for setting the relative position: #11678

It will be available with the next rc version.

from fundamental-ngx.

InnaAtanasova avatar InnaAtanasova commented on September 10, 2024 1

here

Hi Julia, it makes sense what you wrote but since this is an existing component already used in many applications we don't want to break something on user's side. Our practice is to always keep the default behaviour as it was and add new functionality with props so the changes on applications side are minimal or none.

from fundamental-ngx.

InnaAtanasova avatar InnaAtanasova commented on September 10, 2024

Hi @julia-siegl you can add a very quick fix to your project by adding position relative to the dynamic page.
If you add

<ng-template #startColumn>
    <fd-dynamic-page [autoResponsive]="true" ariaLabel="Example Dynamic Page" style="position: relative;">
       ...
    </fd-dynamic-page>
</ng-template>

it will result to this:
Screenshot 2024-04-01 at 2 35 23 PM

from fundamental-ngx.

julia-siegl avatar julia-siegl commented on September 10, 2024

Hi @InnaAtanasova, thank you for providing this solution.
One remark, wouldn't it make sense to set the default positionRelative to true rather than false here to a) be in alignment with the guideline and b) since other bar / footer bar types (e.g. 'normal' footer here), are by default relative?

from fundamental-ngx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.