Weird bug when hovering on Video and in the SVGS about awesome-talks

[pksjce]

@onstash - To fix this bug, I would follow the steps below

1. Consistently reproduce the bug and inform us of the enviroment. Ppl in this thread seemed to have worked on it. Verify that its true.
2. Look for logs on the browser's console indicative of the error.
3. All the code for this part of the feature is in https://github.com/SaraVieira/awesome-talks/blob/master/src/Components/CinemaMode/index.js Maybe start investigating there?

[pksjce]

@onstash - Lets try to debug this ourselves first 👍 I'm also seeing the issue quite consistently on Chrome. Will try to see if I can find out why :)

[sudovijay]

can't reproduce this error, lets call it a hidden effect 🙂 could be browser issue though

[SaraVieira]

Oh, what browser are you using?

[hosmelq]

I could only reproduce this on Linux and Windows machines.

[sudovijay]

did tried on Chrome 67.0 , Firefox 60 & Safari 11.1, seems to work fine for me 🙂 on mac os though,

[SaraVieira]

Weird, I'll try again

On Sat, 2 Jun 2018, 19:11 Vijay Singh, ***@***.***> wrote: did tried on Chrome 67.0 , Firefox 60 & Safari 11.1, seems to work fine for me 🙂 on mac os though, — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#59 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABALdZwWvPA_nYqoW1gdfE9qyLz0OjUBks5t4sdXgaJpZM4UV2tb> .

-- Thank you Sara Vieira

[onstash]

Hi @SaraVieira. I would like to contribute to fixing this issue. But I have not worked with SVGs and video. Could you please point me in a direction to solve this? Thank you in advance. 😃

[sudovijay]

@onstash you might wanna try this on a local env with dev version of react as that'll show much better logs. much easier to debug actually and start with window machine as @hosmelq can reproduce this on it .

[onstash]

Thanks for the detailed inputs, @pksjce and @sudovijay. Unfortunately, I don't have a Windows machine. I use a MacBook Pro.

1. I was able to consistently reproduce the bug on Chrome v66.0.3359.181 and Opera v53.0 on my MacBook Pro running macOS Sierra v10.12.6. I couldn't reproduce the bug on Firefox v60.0.1.

   Steps to reproduce the bug (it's a visual jank) -

   • Load any talk in cinema mode
   • Keep the talk video playing
   • Hover over either the Watched or Favorite SVG icons

2. There were no logs pointing to the error.

3. All the code related to Watched and Favorite(in the player) are present here and here.

I have not worked with SVGs before. So I couldn't find out what's causing the issue and why. So sorry about that. How about we tag / loop-in people who know SVGs better like Sarah Drasner?

[sudovijay]

@onstash Tag Sarah Drasner? lol your not serious bro 🙂 anyway about reproducing the bug try updating your chrome ( current vers. 67.0.3396.79) for mac & lemme know if you can still reproduce it as i can't, everything seems fine to me, can't be SVGs though.

[onstash]

When I hid the SVGs using "display: none" technique / hack, I could not find the jank issue. That's why I suggested we tag Sarah Drasner and people who have worked with SVGs.

[onstash]

Sure, @pksjce. 😄 Apologies for my inability to contribute to this issue, though. 😞