Want to upgrade React Native version to latest 0.62+

sanjeevyadavIT

Hi, I like you project, and would like to contribute, the first thing I can think of is to upgrade the React Native version from 0.49.5 to 0.62.+ do you want contribution?

saru2020

Sure @Sanjeev. It’d be great. Please go ahead and raise a PR On Sat, 18 Apr 2020 at 1:42 PM, Sanjeev yadav <[email protected]> wrote: > Hi, I like you project, and would like to contribute, the first thing I > can think of is to upgrade the React Native version from 0.49.5 to 0.62.+ > > do you want contribution? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/saru2020/Musicly/issues/2>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAH4VJFYLDK7PSDOG4NW3JTRNFOFNANCNFSM4MLIGQNA> > . > -- Thanks! Saravanan

sanjeevyadavIT

Hi @saru2020 I started cloning the project, but saw that you have pushed `node_modules` folder alongside your code. We never upload `node_modules` folder, because they tend to range from 200 to 400MB and the reason we have dependency mentioned in `package.json` so that user can clone the repo and run `npm install` locally. Is it possible that you can remove the node_modules folder from git tracking, and push a commit that will not contain `node_modules` folder, this will make cloning extremely fast, as this will significantly decrease the overall size of the repository ### Steps you need to take [SO answer](https://stackoverflow.com/questions/24290358/remove-a-folder-from-git-tracking) 1. Open the root of the project in terminal 2. Run following command ```bash git rm -r --cached node_modules/ ``` 3. Make a commit and push the commit on github and I see you have pushed a lot of build folders, that we generally omit(do not commit and push on repo), like `.gradle`, `build` folder in android, and I'm sure same will be the case in iOS, the problem arises because you don't have `.gitignore` file in your root directory which tells git which file not to track here's the example of .gitignore file for react-native projects [link](https://github.com/alexakasanjeev/magento_react_native/blob/develop/.gitignore) Even if you can't remove other folder, it would be a great help if you could remove `node_modules` folder, rest I can fix it :)

sanjeevyadavIT

Hi @saru2020 any updates on my above message?

saru2020

Hi @alexakasanjeev, Thanks for your inputs. These messes are created during mindless commits (Read ignorant minds here) ;) Please check my last commit, hope I've cleaned up the mess. You should be good to go now.