Comments (5)
The versions mentioned in the issue for the following packages differ from the latest versions on npm:
react-native-pager-view
(found:5.4.9
, latest:5.4.24
)react-native
(found:0.64.3
, latest:0.69.0
)expo
(found:44.0.0
, latest:45.0.6
)
Can you verify that the issue still exists after upgrading to the latest versions of these packages?
from react-native-tab-view.
The versions mentioned in the issue for the following packages differ from the latest versions on npm:
react-native-pager-view
(found:5.4.9
, latest:5.4.24
)react-native
(found:0.64.3
, latest:0.69.0
)expo
(found:44.0.0
, latest:45.0.6
)Can you verify that the issue still exists after upgrading to the latest versions of these packages?
Upgraded to expo
v45.0.6
, react-native-pager-view
v5.4.24
and react-native
v0.68.2
because v0.69.0
isn't compatible with expo
.
I verify the issue is still happening.
from react-native-tab-view.
This previous issue was closed due to no repro steps. It is the same bug.
from react-native-tab-view.
This issue is actually in react-native-pager-view
. We've added a patch using patch-package to end the swipe when it goes out of the tabview area to fix this temporarily.
diff --git a/node_modules/react-native-pager-view/.DS_Store b/node_modules/react-native-pager-view/.DS_Store
new file mode 100644
index 0000000..7083c2c
Binary files /dev/null and b/node_modules/react-native-pager-view/.DS_Store differ
diff --git a/node_modules/react-native-pager-view/ios/.DS_Store b/node_modules/react-native-pager-view/ios/.DS_Store
new file mode 100644
index 0000000..40daf43
Binary files /dev/null and b/node_modules/react-native-pager-view/ios/.DS_Store differ
diff --git a/node_modules/react-native-pager-view/ios/ReactNativePageView.m b/node_modules/react-native-pager-view/ios/ReactNativePageView.m
index 9f8ed5b..8ddad58 100644
--- a/node_modules/react-native-pager-view/ios/ReactNativePageView.m
+++ b/node_modules/react-native-pager-view/ios/ReactNativePageView.m
@@ -476,6 +476,16 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView {
CGFloat contentOffset =[self isHorizontal] ? scrollView.contentOffset.x : scrollView.contentOffset.y;
CGFloat topBound = [self isHorizontal] ? scrollView.bounds.size.width : scrollView.bounds.size.height;
+ // If a drag goes outside of the content container it should end the drag
+ CGFloat lastContentOffset = [self isHorizontal] ? self.lastContentOffset.x : self.lastContentOffset.y;
+ if (contentOffset <= 0 && lastContentOffset != 0) {
+ scrollView.scrollEnabled = NO;
+ scrollView.scrollEnabled = YES;
+
+ [self goTo:position animated:YES];
+ return;
+ }
+
if ((isFirstPage && contentOffset <= topBound) || (isLastPage && contentOffset >= topBound)) {
CGPoint croppedOffset = [self isHorizontal] ? CGPointMake(topBound, 0) : CGPointMake(0, topBound);
scrollView.contentOffset = croppedOffset;
from react-native-tab-view.
Hey! Thanks for opening the issue. Seems that this issue is in react-native-pager-view
library which is a dependency of react-native-tab-view
. Can you also post your issue in this repo so that it's notified to the maintainers of that library? This will help us fix the issue faster since it's upto the maintainers of that library to investigate it.
from react-native-tab-view.
Related Issues (20)
- Can we support a sticky tab bar to support render a header component for tab view HOT 7
- Does not scroll to latest content HOT 6
- Tab label gets faded out while swiping HOT 6
- How to not rerender all tabs when swipe to another tab ? HOT 3
- Supporting Reanimated 3 HOT 3
- Can i jumpTo withoutAnimation? HOT 5
- [@react-navigation/material-top-tabs] gestureResponseDistance does not work when top tabs nested within a stack navigator HOT 4
- IOS Not full animation to the pressed tab when keyboard is opened HOT 5
- Tab View inside Flatlist not shown content HOT 5
- Collapsible Header HOT 7
- Color the inactive bar HOT 3
- index in navigationState is ignored HOT 2
- Many useless re-renders HOT 16
- Many useless re-renders HOT 2
- Extra height on tab view with fabric enabled HOT 8
- Migrate to Material You tabs design HOT 2
- Lagging during vertical scroll when using webview on android HOT 2
- The tab header not sync with scene swipe when header is long HOT 2
- Initial tab in child tab view flickers while using react-native-tab-view HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-tab-view.