GithubHelp home page GithubHelp logo

Pastel colors after 0.4.3 about wiz_light HOT 9 CLOSED

martroy avatar martroy commented on July 17, 2024
Pastel colors after 0.4.3

from wiz_light.

Comments (9)

sbidy avatar sbidy commented on July 17, 2024 1

Yes, between these two releases, the library behind was changed. I have to check if there are values not correct set.
Because the color was calculated with the RGB (color) and CW (cold warm led) this can cause in a less saturated color.

from wiz_light.

martroy avatar martroy commented on July 17, 2024 1

Hi,

For HASS, I thought that the saturation was controlled by the color wheel, the outside ring being the most saturated? Isn't there a way to mimic 0.4.2 (pywizlight 0.4.12) behavior?

Here is a video to better illustrate what I mean:
https://user-images.githubusercontent.com/59968986/146394444-fbd9573b-10f8-44b5-a0a8-3a119ca8b392.mp4

You can see that, when clicking near the white circle for some of the colors, it drops back the saturation. The same behavior occurs with the bulb itself: the color is fully saturated for a fraction of a second then drops to the less saturated color. Unfortunately, it is hard to show that in a video.

One thing I've noticed is that the amount it drops back seems to follow a certain curve depending on how close the color is from one of the color that works. This would lead me to think that there is a problem when calculating one of the values. But, then again, I haven't looked at the code so I might be completely wrong on this...

Thanks for you hard work btw!

from wiz_light.

dfayne avatar dfayne commented on July 17, 2024

I am seeing a similar issue. I have my bulbs bridged to HomeKit via HASS Bridge. When setting the color to Red for example in Apple's Home App, the bulb changes to a pink-ish color. Blue comes us as a very pale blue. However, if I ask Siri to change the color to red it's fully saturated. I am no programmer so I have no clue if this is an issue with this integration or the HASS bridge but it did pop up after installed 0.4.3.

from wiz_light.

martroy avatar martroy commented on July 17, 2024

I did a bit more testing today. I've tried deleting all the bulbs and re-adding them using the integration UI but I am still getting the same behavior. What appears to happen is that for some colors, the picker will not let me select the full color that is on the outside ring. When setting it, it will always go back to a less saturated tone.

As an example, selecting the orange-red color shows the problem:
wrong

The red doesn't have the problem:
right

I am not sure but it looks like "pure" colors are fine but not the in between ones. Sometimes, when changing to one of the problematic hues, the light has the right color but slowly fades to a pastel tone.

from wiz_light.

sbidy avatar sbidy commented on July 17, 2024

It seems to be an issue with the red channel only.

from wiz_light.

martroy avatar martroy commented on July 17, 2024

It seems to be an issue with the red channel only.

Are you sure about that? I've just tested all of the colors and I am experiencing this with most of the colors except those that are "pure". Those with the green lines are ok. The red ones won't let me select the most saturated color.
Screenshot 2021-12-12 151616

from wiz_light.

sbidy avatar sbidy commented on July 17, 2024

Yes, this "issue" comes from the computation of the saturation value. The library will add for these colors the white LED as saturation value. In the Wiz App you can switch between these two modes via Scenes, HASS doesn't have the possibility to add a kind of saturation slider.

from wiz_light.

sbidy avatar sbidy commented on July 17, 2024

Fixed (hopefully) in Version 0.4.5 - please update

from wiz_light.

martroy avatar martroy commented on July 17, 2024

Yes, it works perfectly now. Thank you so much!

from wiz_light.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.