inquirer/confirm accepts more than just 'Y' and 'n' answers. about inquirer.js

[LitoMore]

If a non 'Yes' or 'no' answer is selected, the program should either throw an error that has to be handled, or it could just ask the question again (specifying that the initial input was wrong).

Good point. I seem to have seen similar interactions before.

[LitoMore]

The code is here:

Inquirer.js/packages/inquirer/lib/prompts/confirm.js

Lines 16 to 25 in a9a0039

	Object.assign(this.opt, {
	filter(input) {
	let value = rawDefault;
	if (input != null && input !== '') {
	value = /^y(es)?/i.test(input);
	}
	return value;
	},
	});

@rrohans Could you give more background about your scenario and your expected behavior?

@SBoudrias Maybe we can change the logic below will be better:

Object.assign(this.opt, {
  filter(input) {
    if (input != null && input !== '') {
      if (/^y(es)?/i.test(input)) return true;
      if (/^n(o)?/i.test(input)) return false;
    }

    return rawDefault;
  },
});

Or change it to:

if (/^(y|yes)$/i.test(input)) return true;
if (/^(n|no)$/i.test(input)) return false;

[rrohans]

Yeah sure. I was scaffolding a new T3 app using their create t3-app cli tool when I noticed a bug in the way they accept confirm-style inputs. I created an issue with their cli tool and was told that they use Inquirer as part of their cli tool. Upon further inspection, I found that the bug is not with their cli but with inquirer itself, as you pointed out in the code above. Ideally, if a non 'Yes' or 'no' answer is selected, the program should either throw an error that has to be handled, or it could just ask the question again (specifying that the initial input was wrong).