GithubHelp home page GithubHelp logo

Comments (5)

sbromberger avatar sbromberger commented on May 12, 2024

SimpleWeightedGraphs is going to suffer major breakage soon with 0.7 anyway since our unsafe view will cause segfaults.

from simpleweightedgraphs.jl.

sbromberger avatar sbromberger commented on May 12, 2024

hm. I can't reproduce this in the latest master:

julia> g = SimpleWeightedDiGraph(3)
{3, 0} directed simple Int64 graph with Float64 weights

julia> inneighbors(g, 3)
0-element Array{Int64,1}

from simpleweightedgraphs.jl.

sbromberger avatar sbromberger commented on May 12, 2024

@simonschoelly - can you test the latest master on 1.0 for performance? I want to make sure we don't have any regressions.

from simpleweightedgraphs.jl.

simonschoelly avatar simonschoelly commented on May 12, 2024

I think the reason for that error was, that you had code of the form

mat  = g.weights'
mat.rowval

which does now work because mat is of type Adjoint. Now you are doing

mat = SparseMatrixCSC(g.weight')
mat.rowval

which does work. The tests for the latest master pass on 1.0. Is that what you mean by performance?

from simpleweightedgraphs.jl.

sbromberger avatar sbromberger commented on May 12, 2024

I'm going to close this out because it's fixed in master.

from simpleweightedgraphs.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.