Comments (16)
Maybe, it's a good idea to re-add the initial test case I added to #61, which then got reverted in #63 + #64, apparently due to the race condition.
from sbt-osgi.
Maybe, it's a good idea to re-add the initial test case I added to #61, which then got reverted in #63 + #64, apparently due to the race condition.
@lefou PR made at #97 and it passes
from sbt-osgi.
@romainreuillon Should I assign you this issue? I noticed that you made some PR's on this topic so you seem to know the most about this problem
from sbt-osgi.
I think this PR: 65ad38f fixes this issue doesn't it?
Can you try @lefou?
from sbt-osgi.
I thought that too, but if I understood @mdedetrich correctly, sbt-osgi 0.9.8
(which contains the fix) does not work with Pekko, whereass the specially released sbt-osgi v0.9.4-INVALID-CEN-JAR-PATCH
does.
from sbt-osgi.
@romainreuillon I have already merged that PR and made a release of sbt-osgi (v0.9.8
) and it didn't solve the issue (at least for Pekko)
from sbt-osgi.
I thought that too, but if I understood @mdedetrich correctly, sbt-osgi
0.9.8
(which contains the fix) does not work with Pekko, whereass the specially released sbt-osgiv0.9.4-INVALID-CEN-JAR-PATCH
does.
Maybe you can try and replicate it on your end, if it did end up solving the issue for you maybe we have multiple issues (and/or I didn't test correctly in which case I would do it again).
from sbt-osgi.
@mdedetrich Can you post the error and/or give a link the the build logs?
from sbt-osgi.
The core issue is here apache/pekko#757 but the error I get is apache/pekko#745 (comment), i.e. there appears to be multiple classes in the produced jar's?
Let me know if I need to provide additional info
from sbt-osgi.
Thanks. As stated previously in the various Akka vs. OSGi tickets, I no longer have any sbt project that uses Akka and OSGi. I still have OSGi projects but I build them with Mill now, where this issues does not occur, as Mill has a more proper cache and output concept than sbt. I do not plan to work on these issue again, but I wanted to point out potential related issues as I felt kind-of responsible, as it was my PR that introduced the race condition. I'm happy that one is fixed. I now think the multiple classes issue in unrelated.
from sbt-osgi.
I think we can close this issue and assign it to version/milestone 0.9.8.
from sbt-osgi.
Okay, I will do a bit more digging and/or wait for @romainreuillon response (if he has one) to confirm that we are dealing with different separate issues or a rather a single one.
from sbt-osgi.
Maybe, it's a good idea to re-add the initial test case I added to #61, which then got reverted in #63 + #64, apparently due to the race condition.
Ill get to this during the week
from sbt-osgi.
Indeed I have not encountered this kind of error message yet.
from sbt-osgi.
@lefou @romainreuillon So shall I close this issue since its been confirmed that the problem Pekko is experiencing specifically is another issue and this issue is actually solved?
from sbt-osgi.
@mdedetrich Yeah, this issue is fixed now. Thank you for re-adding the tests.
from sbt-osgi.
Related Issues (20)
- Fix regression when using Jar's to force proper manifest files HOT 2
- `Compile / sbt.Keys.packageBin := bundle.value` can cause infinite recursive loop HOT 2
- Duplicated `META-INF/MANIFEST.MF` entries when using `packageWithJVMJar := true` on Windows HOT 10
- Write tests for caching functionality
- 0.93 for sbt 0.13 HOT 1
- Document how to publish OSGi bundles
- Missing imported versions for packages from project dependencies
- No sbt 0.13 artefact available 0.9.4 and forward HOT 2
- How to exclude libraries that are marked with Provided HOT 1
- Release 0.9.5 HOT 7
- version 0.9.5 release notes? HOT 1
- Travis CI is dropped HOT 1
- `ConcurrentModificationException` when bunding on JDK17 HOT 1
- sbt-osgi disapeared for the maven repo HOT 3
- Publish to Maven central using sbt-ci-release and groupId `com.github.sbt` HOT 5
- Should we recruit new maintainers? HOT 4
- Change from travis to github actions
- Make a custom release of sbt-osgi 0.9.4 + Invalid CEN extra data field patch HOT 8
- Release notes for 0.9.6 and 0.9.7? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-osgi.