Comments (12)
@ChrisCraig68 @junaidrsd I have the same issue, went from 2.0.1 to 2.0.4. Reverting back to 2.0.1 works for now.
from sc5-styleguide.
@mikezks I've tested once again with all possibilities and styles are working for me. Can you check by deleting output folder. It should work
from sc5-styleguide.
Hi @ChrisCraig68, It seems this is only happening to the clean build. I'll have a look when I get time. Thanks
from sc5-styleguide.
Thanks @junaidrsd
from sc5-styleguide.
@OliverJEvans Thanks that worked for me.
from sc5-styleguide.
I see the same thing. Not sure why this issue got closed, the bug still remains. I'd leave this open until this gets fixed by @junaidrsd 's pull request.
from sc5-styleguide.
@junaidrsd, could you please reopen this issue?
The problem as mentioned in the initial post still persists.
I tested version 2.1.0 (git clone) and 2.0.4 (git clone and npm package) and the styles still do not work.
Thanks!
from sc5-styleguide.
@junaidrsd, thanks for your reply.
It seems to be related to the npm version. In the environment I tried to setup the styleguide today a npm 3.x.x version is allowed only. This seems to be the reason for the wrong styles. I tested it on another PC right now (with npm 5.4.2) and - as you said - everything works fine. Sorry for this confusion, but at least it may be helpful for others as well.
The issue can of course be closed again.
from sc5-styleguide.
@junaidrsd, in contrast to what I wrote yesterday I do have the styles issue with npm 5.4.2 as well. It seems to be connected to the browser.
This bug does not occur in IE, edge, Firefox, but in Chrome only.
Could you please give me feedback whether you tested successfully with Chrome as well?
I tested with Chrome Version 61.0.3163.100 (Official Build) (64-bit)
and Version 60.0.3112.90 (Official Build) (64-bit)
.
Steps to reproduce:
git clone http://github.com/SC5/sc5-styleguide.git
cd sc5-styleguide
npm install
npm run build
npm run demo
from sc5-styleguide.
I think I found a solution resp. workaround:
Chrome does not like this code block:
<script type="text/ng-template" id="userStyles.html">
<style>
@import url('{{{appRoot}}}/styleguide.css');
@import url('{{{appRoot}}}/styleguide_pseudo_styles.css');
@import url('{{{appRoot}}}/styleguide_helper_elements.css');
</style>
</script>
But loading it with your addCssLink()
function works.
from sc5-styleguide.
Thanks @mikezks for reporting problems, unfortunately I'm occupied with other things. If you have found a solution just create a PR I'll merge it.
from sc5-styleguide.
@junaidrsd Here is a pull request that fixes the issue #1130.
from sc5-styleguide.
Related Issues (20)
- Generate static docs
- Error in Demo Build HOT 3
- Wrapper markup PUG
- Search not working to well HOT 1
- Unable to parse custom variables
- Line comments in default CSS results in parse error
- Test suite fails to run without mocha dependency HOT 1
- Markdown code block html entities HOT 2
- Element states like :hover doesn't work
- namespaced positions.
- Please publish v2.1.0 to npm HOT 5
- customColors option is breaking Gulp watch
- gulp-util is deprecated, consider replacing it to support Gulp v4 HOT 2
- After 2.1.0 update - ERROR: Unable to exclude default styles HOT 7
- Broken background-image paths
- Find DOM element with jQuery
- Prevent source files being copied inside of the destination folder
- failing unit tests
- (security alert) morgan needs to be updated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sc5-styleguide.