GithubHelp home page GithubHelp logo

Photo Album features about socify HOT 11 OPEN

scaffeinate avatar scaffeinate commented on June 29, 2024
Photo Album features

from socify.

Comments (11)

scaffeinate avatar scaffeinate commented on June 29, 2024 2

@w0www Cool. Thanks 👍

from socify.

scaffeinate avatar scaffeinate commented on June 29, 2024

@w0www Yes it is still not stable yet. I need to fix a few issues before merging it back to master. And since this links to a blog post tutorial I am planning to create a separate branch for that and then merge everything into master 👍

from socify.

w0www avatar w0www commented on June 29, 2024

@sudharti Ok!! thanks. I am advancing in a fork. You can see the changes my master branch. I have photoAlbum but get some errors.

from socify.

scaffeinate avatar scaffeinate commented on June 29, 2024

@w0www Could you tell me more info on the error you are facing?

from socify.

w0www avatar w0www commented on June 29, 2024

Now appear this error:
When i start the app i see:
ActionController::UrlGenerationError at /
No route matches {:action=>"mentionable", :controller=>"users", :id=>nil} missing required keys: [:id]

in app/views/comments/_form.html.erb

But before when i had created the PhotoAlbum appeared an error that said "not commentable method for Class"

from socify.

w0www avatar w0www commented on June 29, 2024

seleccion_001

from socify.

scaffeinate avatar scaffeinate commented on June 29, 2024

@w0www From your Pull Request https://github.com/w0www/socify/pull/2 I see you have merged develop into master. Develop has a lot of new features and refactoring. So you cannot automatically merge it. Some files need to be reviewed. Didn't you get any conflicts while merging? Or if you had rebased you would have got a few merge conflicts.

from socify.

scaffeinate avatar scaffeinate commented on June 29, 2024

The problem you are facing is because the develop branch doesn't have the mentionable feature yet. If you see https://github.com/sudharti/socify/blob/develop/app/views/comments/_comment.html.erb and the one in master https://github.com/sudharti/socify/blob/master/app/views/comments/_form.html.erb. You see the master one has user mentionable feature while develop doesn't. I will work on merging it onto master. But if you want to resolve it you need to update it to the latest in develop.

from socify.

w0www avatar w0www commented on June 29, 2024

@sudharti yes i get a lot of conflicts while merging.

First i have tried merge Master into develop to get the last changes of master. Then i have done a PR from develop to Master without conflicts.

I may be wrong when i do merge because I not know the changes

from socify.

scaffeinate avatar scaffeinate commented on June 29, 2024

@w0www Sorry about that. I did receive a few Pull Requests to master while I was working on the develop branch. So kind of messed up a little there. But I will be merging develop into master once it's stable. I will keep this issue open. Will notify you if you want.

from socify.

w0www avatar w0www commented on June 29, 2024

Yes, please notify me. And if you has more ideas or more features, i can help you, you know! ;)

Thanks mate!

from socify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.