GithubHelp home page GithubHelp logo

Comments (5)

dorothyDorothy avatar dorothyDorothy commented on August 20, 2024

Tried on node version v18.16.0 and it didn't work. Tried again on node v18.17.1
Still getting
https://codeload.github.com/hugomrdias/concat-stream/tar.gz/057bc7b5d6d8df26c8cf00a3f151b6721a0a8034: Request failed \"404 Not Found\
yarn start fails

from scaffold-eth-challenges.

ottodevs avatar ottodevs commented on August 20, 2024

Tried on node version v18.16.0 and it didn't work. Tried again on node v18.17.1 Still getting https://codeload.github.com/hugomrdias/concat-stream/tar.gz/057bc7b5d6d8df26c8cf00a3f151b6721a0a8034: Request failed \"404 Not Found\ yarn start fails

Take a look to my solution, I did it for challenge-2 branch, but it should also fix this challenge-1 as it is the same issue. I will do another PR for that one as well

from scaffold-eth-challenges.

Maximesol avatar Maximesol commented on August 20, 2024

The probleme still the same, do we have a solution ?

from scaffold-eth-challenges.

fremdelve avatar fremdelve commented on August 20, 2024

Tried on node version v18.16.0 and it didn't work. Tried again on node v18.17.1 Still getting https://codeload.github.com/hugomrdias/concat-stream/tar.gz/057bc7b5d6d8df26c8cf00a3f151b6721a0a8034: Request failed \"404 Not Found\ yarn start fails

Take a look to my solution, I did it for challenge-2 branch, but it should also fix this challenge-1 as it is the same issue. I will do another PR for that one as well

Hi @ottodevs, for Challenge-0, I tried the changes you made for the dependencies and I was able to install properly the dependencies and then running yarn chain, but when trying yarn deploy I'm getting several errors(guessing that they are maybe related to the openzepellin versions, mine are "@openzeppelin/contracts": "^4.3.3" and "@openzeppelin/contracts-upgradeable": "^4.4.1", ). Did you face any similar problem?

The errors are:

TypeError: Function has override specified but does not override anything.
--> contracts/YourCollectible.sol:40:16:
|
40 | ) internal override(ERC721, ERC721Enumerable) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Invalid contracts specified in override list: "ERC721" and "ERC721Enumerable".
--> contracts/YourCollectible.sol:40:16:
|
40 | ) internal override(ERC721, ERC721Enumerable) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract:
--> @openzeppelin/contracts/token/ERC721/ERC721.sol:19:1:
|
19 | contract ERC721 is Context, ERC165, IERC721, IERC721Metadata {
| ^ (Relevant source part starts here and spans across multiple lines).
Note: This contract:
--> @openzeppelin/contracts/token/ERC721/extensions/ERC721Enumerable.sol:14:1:
|
14 | abstract contract ERC721Enumerable is ERC721, IERC721Enumerable {
| ^ (Relevant source part starts here and spans across multiple lines).

TypeError: Function needs to specify overridden contract "ERC721URIStorage".
--> contracts/YourCollectible.sol:63:9:
|
63 | override(ERC721, ERC721Enumerable)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract:
--> @openzeppelin/contracts/token/ERC721/extensions/ERC721URIStorage.sol:12:1:
|
12 | abstract contract ERC721URIStorage is IERC4906, ERC721 {
| ^ (Relevant source part starts here and spans across multiple lines).

TypeError: Derived contract must override function "_beforeTokenTransfer". Two or more base classes define function with same name and parameter types.
--> contracts/YourCollectible.sol:10:1:
|
10 | contract YourCollectible is
| ^ (Relevant source part starts here and spans across multiple lines).
Note: Definition in "ERC721":
--> @openzeppelin/contracts/token/ERC721/ERC721.sol:437:5:
|
437 | function _beforeTokenTransfer(address from, address to, uint256 firstTokenId, uint256 batchSize) internal virtual {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: Definition in "ERC721Enumerable":
--> @openzeppelin/contracts/token/ERC721/extensions/ERC721Enumerable.sol:60:5:
|
60 | function _beforeTokenTransfer(
| ^ (Relevant source part starts here and spans across multiple lines).

TypeError: Wrong argument count for function call: 3 arguments given but expected 4.
--> contracts/YourCollectible.sol:41:9:
|
41 | super._beforeTokenTransfer(from, to, tokenId);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

from scaffold-eth-challenges.

ottodevs avatar ottodevs commented on August 20, 2024

Hi @fremdelve and @Maximesol I just would like to suggest taking a look to this other repo: https://github.com/scaffold-eth/se-2-challenges/, where there is lot of effort put into adapting the challenges to version 2 of scaffold eth, and most of the issues we were discussing here were already fixed.

I solved most of the challenges by just using that other repo instead. This one seems abandoned for some months now.

from scaffold-eth-challenges.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.