Comments (4)
I didn't completely get it π but are we talking about showing something more visual for the amount staked? something like this maybe?
I wasn't very clear with that description π. In the SE1 version after the threshold is met, the timeleft is 0, and someone calls execute, it calls complete() in the ExampleExternalContract.sol contract and actually stakes the Eth. Then this huge banner appears at the top(my example says 0 but it would have the real amount)
This shows the user that since all checks were met the Eth got actually staked.
In the current SE2 version, all that happened is that the total staked here went to 0 with no other way of notifying the user what just happened.
I think the users could benefit from something else appearing saying how much was staked.
from se-2-challenges.
Tysm @ZakGriffith this are great suggestions π
Is it possible to default the debug tab to land on the Staker.sol contract upon their initial visit?
fixed in #34
This is more of a general SE-2 discussion. What about moving the Tx pop-up to be below the top tabs?
Not sure about this, like in most apps usually they appear from top of the screen that's why it defaults in SE-2 but happy to update if others agree π
We need a more clear complete() process. Currently, all that changes is the total staked on the Staker UI tab as seen in the screenshot. The old challenge had an atrocious bar that appeared at the top, so let's avoid it being that gross. Possibly something that appears above the main Staker UI box displaying the amount staked?
I didn't completely get it π
but are we talking about showing something more visual for the amount staked? something like this maybe?
from se-2-challenges.
I wasn't very clear with that description π. In the SE1 version after the threshold is met, the timeleft is 0, and someone calls execute, it calls complete() in the ExampleExternalContract.sol contract and actually stakes the Eth. Then this huge banner appears at the top(my example says 0 but it would have the real amount)
Tysm @ZakGriffith for noticing π, I just missed this part in challenge-1
Updated #34 with something like this :
Please feel free to request for any changes on #34 π
from se-2-challenges.
That is perfect, nice!!
from se-2-challenges.
Related Issues (20)
- Challenge 4: Potential vulnerability with deposit function
- Challenge 4: Suggestions for UI/UX HOT 2
- challenge 6: Add toast notification when sending transactions
- challenge 6: update `backend-local` to use TS HOT 1
- challenge 6: update `backend-local` to use JSON file as db HOT 26
- Challenge 6: Require "New nΒΊ of signatures required" >0 when adding or removing signers HOT 3
- Update tests to supplement autograder HOT 5
- Install package too low HOT 2
- Challenge 0 - Workaround for users with IPFS blocked
- Add tests to multisig challenge
- Backmerge vercel deployment fix HOT 2
- Challenge 4: Broken telegram link? HOT 1
- Fix nfts image width
- More ReadMe Consistency Issues HOT 3
- Migration to Wagmi V1 and Viem HOT 2
- Rewrite tests to viem HOT 1
- Challenge 0 - Checkpoint 4 deploy to Vercel build error with defaults HOT 3
- Challenge 0: use different package instead of react-json-view HOT 2
- Challenge 1 Checkpoint 1: Staking - "Stake Events" table data not loading HOT 4
- Backmerge event indexes after merge to se-2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from se-2-challenges.