Challenge 1 Iteration Findings about se-2-challenges

[ZakGriffith]

I didn't completely get it 😅 but are we talking about showing something more visual for the amount staked? something like this maybe?

I wasn't very clear with that description 🙃. In the SE1 version after the threshold is met, the timeleft is 0, and someone calls execute, it calls complete() in the ExampleExternalContract.sol contract and actually stakes the Eth. Then this huge banner appears at the top(my example says 0 but it would have the real amount)

This shows the user that since all checks were met the Eth got actually staked.

In the current SE2 version, all that happened is that the total staked here went to 0 with no other way of notifying the user what just happened.

I think the users could benefit from something else appearing saying how much was staked.

[technophile-04]

Tysm @ZakGriffith this are great suggestions 🙌

Is it possible to default the debug tab to land on the Staker.sol contract upon their initial visit?

fixed in #34

This is more of a general SE-2 discussion. What about moving the Tx pop-up to be below the top tabs?

Not sure about this, like in most apps usually they appear from top of the screen that's why it defaults in SE-2 but happy to update if others agree 🙌

We need a more clear complete() process. Currently, all that changes is the total staked on the Staker UI tab as seen in the screenshot. The old challenge had an atrocious bar that appeared at the top, so let's avoid it being that gross. Possibly something that appears above the main Staker UI box displaying the amount staked?

I didn't completely get it 😅 but are we talking about showing something more visual for the amount staked? something like this maybe?

[technophile-04]

I wasn't very clear with that description 🙃. In the SE1 version after the threshold is met, the timeleft is 0, and someone calls execute, it calls complete() in the ExampleExternalContract.sol contract and actually stakes the Eth. Then this huge banner appears at the top(my example says 0 but it would have the real amount)

Tysm @ZakGriffith for noticing 🙌, I just missed this part in challenge-1

Updated #34 with something like this :

Please feel free to request for any changes on #34 🙌

[ZakGriffith]

That is perfect, nice!!