GithubHelp home page GithubHelp logo

Comments (3)

mertcanciy avatar mertcanciy commented on August 20, 2024
  • The ethToToken, Deposit, and Withdraw inputs will only allow a '.' if you first type in a 0. We should allow them to type something like '.5' instead of forcing '0.5'.
  • The tokenToEth input throws the following error when anything other than a number is entered, including a '.'
    image

This should behave in the same way the other inputs do where if you type a non number or decimal it omits it.

for ethToToken, Deposit, and Withdraw inputs, they are using scaffold-eth's EtherInput component and also tokenToEth is using IntegerInput component. Since they are coming as default and as a part of SE-2, I couldn't know if I should touch them. Shall I try to change these components or I can try to fix without touching the components or maybe @technophile-04 or @carletex can take a look at these components if they built these ones

from se-2-challenges.

technophile-04 avatar technophile-04 commented on August 20, 2024

for ethToToken, Deposit, and Withdraw inputs, they are using scaffold-eth's EtherInput component

Yup this is something we can handle at SE-2, but I have fixed it at #53

also tokenToEth is using IntegerInput component.

Regarding this and UI breaking error that Zak got, Since you have updated IntegerInput to act as normal input (passing hiddendSuffix) and manually parsing the value in useScaffoldContractWrite hook we need to handle it while passing

Fixed it at #53 πŸ™Œ

from se-2-challenges.

technophile-04 avatar technophile-04 commented on August 20, 2024

Closing this since #53 πŸ™Œ

from se-2-challenges.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.