Comments (3)
- The ethToToken, Deposit, and Withdraw inputs will only allow a '.' if you first type in a 0. We should allow them to type something like '.5' instead of forcing '0.5'.
- The tokenToEth input throws the following error when anything other than a number is entered, including a '.'
This should behave in the same way the other inputs do where if you type a non number or decimal it omits it.
for ethToToken, Deposit, and Withdraw inputs, they are using scaffold-eth's EtherInput component and also tokenToEth is using IntegerInput component. Since they are coming as default and as a part of SE-2, I couldn't know if I should touch them. Shall I try to change these components or I can try to fix without touching the components or maybe @technophile-04 or @carletex can take a look at these components if they built these ones
from se-2-challenges.
for ethToToken, Deposit, and Withdraw inputs, they are using scaffold-eth's EtherInput component
Yup this is something we can handle at SE-2, but I have fixed it at #53
also tokenToEth is using IntegerInput component.
Regarding this and UI breaking error
that Zak got, Since you have updated IntegerInput
to act as normal input (passing hiddendSuffix
) and manually parsing the value in useScaffoldContractWrite
hook we need to handle it while passing
Fixed it at #53 π
from se-2-challenges.
Closing this since #53 π
from se-2-challenges.
Related Issues (20)
- Challenge 4: Potential vulnerability with deposit function
- Challenge 4: Suggestions for UI/UX HOT 2
- challenge 6: Add toast notification when sending transactions
- challenge 6: update `backend-local` to use TS HOT 1
- challenge 6: update `backend-local` to use JSON file as db HOT 26
- Challenge 6: Require "New nΒΊ of signatures required" >0 when adding or removing signers HOT 3
- Update tests to supplement autograder HOT 5
- Install package too low HOT 2
- Challenge 0 - Workaround for users with IPFS blocked
- Add tests to multisig challenge
- Backmerge vercel deployment fix HOT 2
- Challenge 4: Broken telegram link? HOT 1
- Fix nfts image width
- Decide how to structure components folders HOT 1
- Add technical breakdown to svg nft challenge
- Rewrite tests to viem HOT 1
- Challenge 0 - Checkpoint 4 deploy to Vercel build error with defaults HOT 3
- Challenge 0: use different package instead of react-json-view HOT 2
- Challenge 1 Checkpoint 1: Staking - "Stake Events" table data not loading HOT 4
- Backmerge event indexes after merge to se-2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from se-2-challenges.