Comments (4)
Fair enough. I really opened this issue to discuss the implications of this. In fact, what I've realised is that scala-steward has been helpful in pointing me at the anomaly in my build.sbt, so that's been valuable. I'll close this issue now.
Thanks very much for making such a useful tool!
from scala-steward.
It seems to me that enumeratum
and enumeratum-circe
have different release cycles and version numbers. Would it make sense to use two vals then for those dependencies?
from scala-steward.
Yeah, I can definitely change the build.sbt to avoid this. In fact, I've already done so by not explicitly depending on enumeratum
and letting it be pulled in as a transitive dependency of enumeratum-circe
. But the main point I was raising is that sometimes scala-steward
makes changes that break the build in this way. I don't know if you think it's worth trying to detect a situation like this, where the variable is used in two places, and resolving it somehow.
from scala-steward.
scala-steward is currently a beefed-up text-based "search and replace". To reliably detect such situations it would need to have a semantic understanding of the things it is trying to change (probably via scalameta) but we're not there yet. Until then I think trying to detect such situations would be like a game of whack-a-mole.
from scala-steward.
Related Issues (20)
- No able to create a pull request Bitbucket HOT 1
- sbt not found with scala-steward-action HOT 1
- no effect with .github/.scala-steward.conf override if PRs has been already created before HOT 2
- Scala Steward run within an org is incorrectly creating PR's against wrong repo HOT 3
- [Bug?] Cannot resolve -p with Mill 0.11.6 HOT 8
- Option to abort on scalafix migration failure HOT 1
- Using custom dependency rules for scalafix-migrations with 'type: "build"'
- Scala Steward runs as root when using the published Docker image (but it probably shouldn't)
- Unable to respect update frequency when version number is stored as a val
- Scala Steward attempting to raise PRs for group branches that already have PRs HOT 3
- Force-pushing over modified branches HOT 5
- Avoid pushing scala updates for non LTS versions HOT 6
- Automatic `buildRoots` detection
- Bitbucket repository name is malformatted in URL
- Clarification of "updatePullRequests" for grouped PRs HOT 4
- Feature to limit branch name length HOT 3
- Wrong targetRefName when create azure-repo PullRequestPayload
- Config option to update files only in defined paths
- Scalafmt cannot run when buildRoots is set
- `scala-cli` dependencies: "WARN Unable to bump version for update [...]"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-steward.