GithubHelp home page GithubHelp logo

Comments (14)

zackangelo avatar zackangelo commented on May 19, 2024

👍

I've modified the Java GRPC compiler to create Scala service stubs instead. I'd be interested in porting that work over if it's something others are interested in.

We'd also need proto3 support. I think we're close, there doesn't seem to be a big difference between the two. The biggest change needed I've found is for all fields to be optional.

from scalapb.

He-Pin avatar He-Pin commented on May 19, 2024

@zackangelo
currently the grpc don't support scala directly,seems like we could leverage work here just as what you said.
it's beta now,I think will be soon to the GA stage.

from scalapb.

tayama0324 avatar tayama0324 commented on May 19, 2024

I am woking on scala gRPC support with @xuwei-k. We will fork ScalaPB rather than sending pull requests to get things done quickly. Let us know if you have any concerns. This issue will be closed in a few days.

from scalapb.

thesamet avatar thesamet commented on May 19, 2024

@tayama0324 nice, would definitely love to have it merged here when you're ready.

from scalapb.

iphydf avatar iphydf commented on May 19, 2024

About making all fields optional: can this be a setting, so I can choose to make all fields non-optional, instead? Wrapping everything in an Option can become too much overhead. The proto3 semantics allow for this (see this example).

from scalapb.

thesamet avatar thesamet commented on May 19, 2024

@iphydf the above comment seem to be unrelated to this bug - can you please file a different issue? FWIW, in Scalapb >= 0.5, primitives are not wrapped in an Option for proto3.

from scalapb.

agnek avatar agnek commented on May 19, 2024

@xuwei-k @tayama0324 can I help you and contribute some code? I want to use grpc at work.

from scalapb.

thesamet avatar thesamet commented on May 19, 2024

Status update: merge @xuwei-k PR into the grpc branch here. Added an implementation of a Marshaller to avoid conversions to/from Java protobufs.

from scalapb.

xuwei-k avatar xuwei-k commented on May 19, 2024

Added an implementation of a Marshaller to avoid conversions to/from Java protobufs.

Excellent! thanks a lot 😄

from scalapb.

thesamet avatar thesamet commented on May 19, 2024

The work has been merged into master and released in 0.5.18. Thanks @xuwei-k for doing the heavy lifting!

from scalapb.

xuwei-k avatar xuwei-k commented on May 19, 2024

FYI, I and @tayama0324 translated grpc-java examples. https://github.com/xuwei-k/grpc-scala-sample

from scalapb.

thesamet avatar thesamet commented on May 19, 2024

This is really awesome - thank you! When I get to write the docs for
ScalaPB/grpc I'll make sure to link to this repo.

On Fri, Dec 18, 2015 at 8:04 PM, kenji yoshida [email protected]
wrote:

FYI, I and @tayama0324 https://github.com/tayama0324 translated
grpc-java examples. https://github.com/xuwei-k/grpc-scala-sample


Reply to this email directly or view it on GitHub
#44 (comment).

-Nadav

from scalapb.

abhinavzspace avatar abhinavzspace commented on May 19, 2024

This is great. Can you show us (java guys) a few hints on where to look for the code for implementing grpc on our projects @xuwei-k and @tayama0324 in https://github.com/xuwei-k/grpc-scala-sample. Thanks a lot for this excellent work.

from scalapb.

mkotsbak avatar mkotsbak commented on May 19, 2024

Documentation: https://scalapb.github.io/grpc.html

from scalapb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.