TrevniScheme, and test case added. about cascading.avro

[kkrugler]

Hi Kidong Lee,

I've taken a look at the patch, and it seems good to me. Though I'm not a Trevni user, so it would be great if you could get Doug to review as well :)

A few questions...

1. There was a change you made to the scheme/pom.xml, for the avro-maven-plugin (https://github.com/mykidong/cascading.avro/commit/893b1e9bb64b12c9eadce68d280c51930835a8a2#L0R64).

Why was this needed?

1. Does the single testSpecifiedColumns() test provide sufficient coverage for Trevni functionality?

It's fine if this only tests a sub-set of the functionality that you're using, but it would be good to add an explicit comment to that effect.

Thanks,

-- Ken

[kkrugler]

Hi Chris,

I'm leaving (I know, again...) in a few days for a two week backpacking trip. I'm assigning this to you in case I can't get everything resolved with Kidong Lee before I leave. Hope that's OK...

-- Ken

[kkrugler]

Hi Ken,

I am using Eclipse, I just added lifecycle-mapping plugin to remove my
eclipse complaining message.
I think, for non-eclipse user, it is not needed.

I don't think, it is sufficient to cover all the trevni funcs just with
testSpecifiedColumns(), but I think, it is the main function when you run
m/r with trevni data format.

I will try to add more test cases for trevni functionalities with more
comments.

• Kidong.

2013/7/24 Ken Krugler [email protected]

Hi Kidong Lee,

I've taken a look at the patch, and it seems good to me. Though I'm not a
Trevni user, so it would be great if you could get Doug to review as well :)

A few questions...

1. There was a change you made to the scheme/pom.xml, for the
   avro-maven-plugin (mykidong@893b1e9#L0R64https://github.com/mykidong/cascading.avro/commit/893b1e9bb64b12c9eadce68d280c51930835a8a2#L0R64
   ).

Why was this needed?

1. Does the single testSpecifiedColumns() test provide sufficient
   coverage for Trevni functionality?

It's fine if this only tests a sub-set of the functionality that you're
using, but it would be good to add an explicit comment to that effect.

Thanks,

-- Ken

—
Reply to this email directly or view it on GitHubhttps://github.com/bixolabs/cascading.avro/pull/21#issuecomment-21444494
.

[kkrugler]

Hi Kidong,
I've been pretty busy this week but should have time in the next day or two to check this out and merge it in. Thanks very much for the help and pull request!

[kkrugler]

Hi Kidong,

Very sorry I haven't gotten to this. I'm going to try and do so this week. Can you open a pull on the new home repository (the Scale Unlimited one referenced in the README.md)?

[kkrugler]

I tried pulling a request, but I have no idea how to pull a request from
the new repo https://github.com/ScaleUnlimited/cascading.avro

• Kidong.

2013/8/19 Chris Severs [email protected]

Hi Kidong,

Very sorry I haven't gotten to this. I'm going to try and do so this week.
Can you open a pull on the new home repository (the Scale Unlimited one
referenced in the README.md)?

—
Reply to this email directly or view it on GitHubhttps://github.com/bixolabs/cascading.avro/pull/21#issuecomment-22898425
.

[kkrugler]

i mean, i cannot send a pull request from the new repo. sorry for my bad
english.

• kidong.

2013/8/19 Kidong Lee [email protected]

I tried pulling a request, but I have no idea how to pull a request from
the new repo https://github.com/ScaleUnlimited/cascading.avro

• Kidong.

2013/8/19 Chris Severs [email protected]

Hi Kidong,

Very sorry I haven't gotten to this. I'm going to try and do so this
week. Can you open a pull on the new home repository (the Scale Unlimited
one referenced in the README.md)?

—
Reply to this email directly or view it on GitHubhttps://github.com/bixolabs/cascading.avro/pull/21#issuecomment-22898425
.

[kkrugler]

Hi kidong,

I assume you cloned the new repo (at https://github.com/ScaleUnlimited/cascading.avro), then rolled in your changes and tried to create a pull request, right?

If so, what didn't work?

Thanks,

-- Ken

[kkrugler]

I had a forked repo from the old bixolab.
I deleted this repo, and I forked the new one from the scale unlimited,
then it works.

I sent a pull request again.

thanks,

• Kidong.

2013/8/20 Ken Krugler [email protected]

Hi kidong,

I assume you cloned the new repo (at
https://github.com/ScaleUnlimited/cascading.avro), then rolled in your
changes and tried to create a pull request, right?

If so, what didn't work?

Thanks,

-- Ken

—
Reply to this email directly or view it on GitHubhttps://github.com/bixolabs/cascading.avro/pull/21#issuecomment-22944046
.

[kkrugler]

Duplicate issue (ported from https://github.com/bixolabs/cascading.avro/pull/21), so I'm closing.