GithubHelp home page GithubHelp logo

Logs are broken about arsenal HOT 6 CLOSED

romfreiman avatar romfreiman commented on August 10, 2024
Logs are broken

from arsenal.

Comments (6)

 avatar commented on August 10, 2024

This means that the tests did not catch a call to the validateAuthConfig function. Fixing the way it's called should be enough.

from arsenal.

romfreiman avatar romfreiman commented on August 10, 2024

can you elaborate please? I actually did nothing on S3 side. Just rebuild the docker image.

from arsenal.

 avatar commented on August 10, 2024

As you can see in https://github.com/scality/Arsenal/pull/314/files#diff-3730f90bb19d3b3646a968c2a4dddbdeL169 ; a project-wide change was made to werelogs to fix an insidious configuration bug; and led to a change in the API of a few common/library functions.

I may have missed some calls to this library in various projects, due to lack of automated testing and attention. If you find any, you may fix it following the method used in the same PR: https://github.com/scality/Arsenal/pull/314/files#diff-a400b2bf757d4e597747b3bd4a2105ddR33

from arsenal.

 avatar commented on August 10, 2024

Alternatively, you may want to make sure you installed the proper versions of arsenal and werelogs, by removing your node_modules, and re-installing the dependencies (since we know npm doesn't handle git branches very well)

from arsenal.

 avatar commented on August 10, 2024

After testing it out, I see it working (of course, you may need to rm -rf node_modules; then npm install ; before this works, as I described earlier).
That being said, I found out an obsolete piece of code in the S3 repository at https://github.com/scality/S3/blob/master/dataserver.js#L15 (The config bit about the logs in this line is not taken into account by Arsenal, so it might as well be removed). I'll leave the S3 team to handle this.

Then, Can we close this issue ?

from arsenal.

romfreiman avatar romfreiman commented on August 10, 2024

Sure. Closing.

from arsenal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.