Comments (6)
I'll provide for the first point a fix early January, thanks.
What is the expected behavior for earlier and later trips?
from public-transport-enabler.
It's basically paging. If you request 4 trips and then request a later 4 trips you should get the same 8 trips you would have gotten if you requested 8 trips to begin with. (Of course if you operate on dynamic data, it can happen that the query for next yields more recent data than you would have gotten at the time of the first call.)
One difference between the various implementations is that some return really only the next trips, and some will repeat everything that was queried already and add the next trips. Öffi tries to accomodate for that, but I suspect there's still bugs lurking. As a rule of thumb, return whatever you get from the server.
from public-transport-enabler.
@schildbach I had set the requested trip count to 1 for testing purposes, but I realised that now navitia returns only one trip unless specified otherwise. Should I take the default trip count for the navitia provider, or hardcode some value?
from public-transport-enabler.
AbstractNetworkProvider has the "numTripsRequested" property. That's the value you should use. Currently the default is set to 6. If Navitia for some reason should have a lower default, it might make sense to refactor the code to allow the service provider pick a default.
from public-transport-enabler.
@grote Could you retest please?
from public-transport-enabler.
I'm getting 6 trips now like expected. Thanks for the fix!
from public-transport-enabler.
Related Issues (20)
- GTFS without Navitia HOT 4
- SNCF real-time data
- Crash on NS (Netherlands) HOT 1
- Location: equals(…) is not symmetric
- IT: java.lang.IllegalArgumentException: Unhandled error id: no_destination
- MVV Trip Delays are always 0 HOT 4
- Add support for STIB (Brussels) HOT 1
- BEG (BayernProvider) has no colors for S-Bahn lines in Munich
- Add support for Zenbus API
- Discussion: Polish GTFS providers? HOT 1
- Suburban trains in Madrid metro area missing
- MVV provider broken HOT 2
- London Elizabeth Line HOT 3
- Error checking for a bus connection
- VVO: UNKNOWN_FROM HOT 1
- SPAIN: java.lang.IllegalArgumentException: Unhandled error id: no_origin
- DB: UNRESOLVABLE_ADDRESS HOT 1
- VGN: platforms missing
- SE: UNRESOLVABLE_ADDRESS
- IT: java.lang.IllegalArgumentException: Unhandled error id: no_origin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from public-transport-enabler.