GithubHelp home page GithubHelp logo

Comments (7)

ulich avatar ulich commented on July 17, 2024

+1

Especially the legal information is something that is important imho. Is it ok to use the APIs of the public transport companies just by using your library (if yes, which)? I imagine that you need to get some permission of them, right? @schildbach What were your experiences with Öffi?

from public-transport-enabler.

jcharaoui avatar jcharaoui commented on July 17, 2024

I'd like to add support for my region (Canada, Quebec) and it looks easy enough but I'm a bit confused with the tests as the implementations vary a bit from region to region. Some quick guidelines to writing tests and an example would be a great help.

from public-transport-enabler.

grote avatar grote commented on July 17, 2024

Hi @jcharaoui, the information in grote/Transportr#144 might help you to get started. You might also be able to team up with @baldurmen.

from public-transport-enabler.

jcharaoui avatar jcharaoui commented on July 17, 2024

Yeah, we're already teamed up, and we're in the same situation. I've also looked at the pull request. My confusion stems from the fact that not all providers implement the same tests routines, and it's not clear to me what values should be provided to each test function call (valid or invalid data? data formatting, etc.).

from public-transport-enabler.

grote avatar grote commented on July 17, 2024

Great to hear that you teamed up already! :)

The tests have been written by different people and can always be improved. The more tests and the more code/API coverage, the better I'd say. Tests for Navitia providers currently in the public transport enabler have obviously been good enough for @schildbach, so this is the lower barrier you need to meet ;)

from public-transport-enabler.

baldurmen avatar baldurmen commented on July 17, 2024

@jcharaoui check this out: #76

The job is actually done, but it should answer your questions about tests

from public-transport-enabler.

grote avatar grote commented on July 17, 2024

Documentation was added with #73. Can we close this issue then?

from public-transport-enabler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.