GithubHelp home page GithubHelp logo

Comments (7)

huangsong avatar huangsong commented on May 23, 2024 4

@yuresko here is my test code. https://github.com/huangsong/instascan/tree/master/docs it work well on my test phone (iphone7p ios 15. 、ipadmin5 12.2, android 12 pixel3),I used the modification and compilation of the code of the master branch

from instascan.

huangsong avatar huangsong commented on May 23, 2024 1

edit scanner.js

    analyze() {
        if (!this.video.videoWidth) {
          return null;
        }
    
        //if (!this.imageBuffer) {
          let videoWidth = this.video.videoWidth;
          let videoHeight = this.video.videoHeight;
    
          this.sensorWidth = videoWidth;
          this.sensorHeight = videoHeight;
          this.sensorLeft = Math.floor((videoWidth / 2) - (this.sensorWidth / 2));
          this.sensorTop = Math.floor((videoHeight / 2) - (this.sensorHeight / 2));
    
          this.canvas.width = this.sensorWidth;
          this.canvas.height = this.sensorHeight;
    
          this.canvasContext = this.canvas.getContext('2d');
          this.imageBuffer = ZXing._resize(this.sensorWidth, this.sensorHeight);
          //return null;
        //}

fix this bug.

from instascan.

DarrylIdle avatar DarrylIdle commented on May 23, 2024

I found that turning the phone landscape fixed the issue for me (may not be the situation for others). I think instascan is analyzing a squished frame/image that it can't recognize.

There might also be some combinations of experimental settings in Safari that could fix it but I haven't the time to screw around with it.

from instascan.

yuresko avatar yuresko commented on May 23, 2024

@huangsong did your snippit resolve it? for me it still only defaults to landscape.

from instascan.

RileyIsOnGitHub avatar RileyIsOnGitHub commented on May 23, 2024

@yuresko let me know if this resolves your issue. I had no luck when trying it.

I'm hoping to hear back from @huangsong regarding my issue I posted yesterday that you responded to. Hopefully he'll be able help.

from instascan.

sandervanschaik avatar sandervanschaik commented on May 23, 2024

@huangsong ... I had the same problem and found this issue via Google. I tried your solution, but it is not working on IOS 15.3.1 (Ipad Air and Iphone8). It remains only working in landscape and not in portrait.

Another bug is the front camera is working, the back camera is not working on both my IOS devices. But maybe I have to put this in another 'issue'.

from instascan.

agusbrand avatar agusbrand commented on May 23, 2024

Worked like a charm ✨ Thanks @huangsong !

from instascan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.