GithubHelp home page GithubHelp logo

Comments (9)

devmotion avatar devmotion commented on June 14, 2024

As the hypothesis above suggests, not setting the initial time step dt = 0.1 in the constrained tests leads to different initial time steps also for the constrained tests (1.0e-06 vs. 0.0001). As a consequence, also the constrained tests fail (see https://ci.appveyor.com/project/devmotion/delaydiffeq-jl-p4v3l/build/job/fhu7jik5t33r1jy6).

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 14, 2024

As the hypothesis above suggests, not setting the initial time step dt = 0.1 in the constrained tests leads to different initial time steps also for the constrained tests (1.0e-06 vs. 0.0001).

That's really weird. Doesn't it suggest there's a difference due to OrdinaryDiffEq.jl and not DelayDiffEq.jl though?

from delaydiffeq.jl.

devmotion avatar devmotion commented on June 14, 2024

I'm not sure yet. At least I could not reproduce the difference with a simple ODE example. Moreover, I discovered that the initial time step in these examples is set to 1.0e-6 on my computer and 9.999999999999999e-5 on Windows 32bit, but still the first non-zero time point of the solution is 1.0e-6 on my computer and 0.0001 on Windows 32bit.

from delaydiffeq.jl.

devmotion avatar devmotion commented on June 14, 2024

Oh my god :D Of course 9.9999e-5 != 1.0e-6

from delaydiffeq.jl.

devmotion avatar devmotion commented on June 14, 2024

Fixed by SciML/OrdinaryDiffEq.jl@b70c49e

from delaydiffeq.jl.

devmotion avatar devmotion commented on June 14, 2024

Seems there is another problem on Windows 32bit that was not fixed by that commit, since now another test fails:
https://ci.appveyor.com/project/ChrisRackauckas/delaydiffeq-jl/build/1.0.96/job/l0ty4hq534tsxhep

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 14, 2024

Only 32-bit and only unconstrained tests with a really small difference? I'll take a quick look but that sounds like a nightmare to find haha.

from delaydiffeq.jl.

devmotion avatar devmotion commented on June 14, 2024

Yes, and it's only one single test.

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 14, 2024

Discussed in #22. The errors are fixed because they needed a higher bound anyways after the OrdinaryDiffEq changes. A lot of this may be due to compiler optimizations not be applied uniformly. Practical steps forward would be to reduce numerical errors all around via things like SciML/OrdinaryDiffEq.jl#93 and summation re-ordering. I'm closing this because I think the @fastmath tests show that the level of accuracy that was looked at here is just beyond our control, but we can focus on SciML/OrdinaryDiffEq.jl#93 instead. Feel free to pursue this further if you want though, and we can re-open if you find something.

from delaydiffeq.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.