GithubHelp home page GithubHelp logo

Comments (9)

ChrisRackauckas avatar ChrisRackauckas commented on June 13, 2024 1

I merged master into your branch and fixed the current in the cache and now it's interpolating properly.

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 13, 2024 1

@YingboMa letting you know this is working

from delaydiffeq.jl.

devmotion avatar devmotion commented on June 13, 2024

I updated the type of the returned solution and added some tests in https://github.com/JuliaDiffEq/DelayDiffEq.jl/tree/composite. However, something seems to be incorrect/broken as the following example of the first Robertson problem in #67 shows:

sol = solve(prob_dde_rober1, MethodOfSteps(AutoTsit5(Rosenbrock23())); initial_order = 1)

all(sol.alg_choice .== 1)

plot(sol)

newplot

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 13, 2024

If you check the solution, at the end the current algorithm should be 2, but all(sol.alg_choice .== 1) is true, so the interpolant is broken since it's using the wrong interpolation.

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 13, 2024

integrator_utils.jl on line 88 has:

      if typeof(integrator.alg) <: OrdinaryDiffEqCompositeAlgorithm
        copyat_or_push!(integrator.sol.alg_choice,integrator.saveiter,integrator.cache.current)
      end

I don't think we update cache.current in the other cache.

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 13, 2024

rober

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 13, 2024

Is the branch missing anything or is it ready to merge? LGTM?

from delaydiffeq.jl.

devmotion avatar devmotion commented on June 13, 2024

No, I guess it's complete and ready to merge. Thanks for the fix!

from delaydiffeq.jl.

ChrisRackauckas avatar ChrisRackauckas commented on June 13, 2024

Thank you too. Good team effort 👍

from delaydiffeq.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.