GithubHelp home page GithubHelp logo

Comments (9)

martindevans avatar martindevans commented on September 26, 2024 1

Yeah to be honest I don't have any experience with the .props file either.

There is a ignore duplicates flag in the csproj that might be of use

I don't think that would work. There are a load of different binaries (noavx, AVX, AVX2, AVX512 etc) which all need to be in different folders, the bug here seems to be that they're all copies to the same place.

Ignoring duplicates would just make your build unreliable, as one of those binaries would basically be selected at random!

from llamasharp.

martindevans avatar martindevans commented on September 26, 2024 1

I just encountered this issue again myself and dug into it. I think #561 should fix it.

from llamasharp.

philippjbauer avatar philippjbauer commented on September 26, 2024

Same here for Windows x64 publishing

from llamasharp.

martindevans avatar martindevans commented on September 26, 2024

It appears that the issue here is publish tries to place all of the various binaries (e.g. avx\libllama.so, avx2\libllama.so, avx512\libllama.so etc) into the root folder. Since they all have the same name and are being placed in the same directory this causes a conflict. They should be placed into separate folders, I'm not sure why publish isn't respecting that.

from llamasharp.

martindevans avatar martindevans commented on September 26, 2024

Publishing LLama.Examples from the main project does work, so this must be an issue with the way the nuget packages are set up. Unfortunately I don't know much about that at all. Is this something you'd be interested in investigating further @JohnGalt1717 ?

from llamasharp.

martindevans avatar martindevans commented on September 26, 2024

Perhaps related to this? https://github.com/SciSharp/LLamaSharp/blob/master/LLama/runtimes/build/LLamaSharpBackend.props

Looks like it tells it to copy all the files to the same directory.

from llamasharp.

JohnGalt1717 avatar JohnGalt1717 commented on September 26, 2024

Perhaps related to this? https://github.com/SciSharp/LLamaSharp/blob/master/LLama/runtimes/build/LLamaSharpBackend.props

Looks like it tells it to copy all the files to the same directory.

I would agree, however I don't have experience with props so I wouldn't feel comfortable changing this.

There is a ignore duplicates flag in the csproj that might be of use, but needs to be made at the package level from what I can tell (doesn't work in any of my projects)

from llamasharp.

alexhiggins732 avatar alexhiggins732 commented on September 26, 2024

Perhaps related to this? https://github.com/SciSharp/LLamaSharp/blob/master/LLama/runtimes/build/LLamaSharpBackend.props
Looks like it tells it to copy all the files to the same directory.

I would agree, however I don't have experience with props so I wouldn't feel comfortable changing this.

There is a ignore duplicates flag in the csproj that might be of use, but needs to be made at the package level from what I can tell (doesn't work in any of my projects)

Ignore duplicates will cause avx\libllama.so, avx2\libllama.so, and avx512\libllama.so to overwrite each other.

from llamasharp.

martindevans avatar martindevans commented on September 26, 2024

Unfortunately that fix didn't work :(

from llamasharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.