How to set the mumps version about mumps

[eike-fokken]

Oh, does this project only work for mumps 5. ...?
Following your github action I just tried to set the version to 5.3.5, which worked.

[eike-fokken]

Ok, now I see, only specific versions are supported.
The sha256 are the checksums of the downloaded tar file, right?

Maybe I'll have a look, whether one could simply add the relevant entry for 4.10.0

Or do you not want that, because 4.10.0 is no longer supported?

[scivision]

OK thanks, I could also make it so that there are a few "known working" MUMPS versions where there is a SHA256 checksum, and then allow additional MUMPS versions where I don't have the SHA256 checksum and haven't checked that the particular MUMPS version works

[scivision]

The current "main" branch commit built for me starting with:

cmake -B build "-DMUMPS_UPSTREAM_VERSION=4.10.0"
cmake --build build

ctest --test-dir build

As I mention above, the SHA256 of the MUMPS source code archive .tar.gz is not checked for the MUMPS versions not in libraries.json.
I based this new arbitrary MUMPS version selection off the Makefile for each version, but there may be omissions/mistakes. So please let me know how it works for you.

Currently you can select any MUMPS >= 4.8 by this means.

[eike-fokken]

Thanks for the quick response! It works for me with the main branch.
But after familiarizing myself with this feature of CMakes FetchContent, I think this behaviour would surprise users (not checking the sha256). Maybe its better to just include

      "4.10.0": {
          "sha256": "d0f86f91a74c51a17a2ff1be9c9cee2338976f13a6d00896ba5b43a5ca05d933",
          "urls": ["http://mumps.enseeiht.fr/MUMPS_4.10.0.tar.gz",
                   "http://graal.ens-lyon.fr/MUMPS/MUMPS_4.10.0.tar.gz"
          ]
      },

(please verify the sha256).

Sorry, I would do a PR, can do that tomorrow, if its easier for you.
Considering the connection to graal is not encrypted, I really prefer checking the sha256 and not giving the user the option to forego it.

[scivision]

Yes I agree that's it's too surprising to allow non-HTTPS without hash. I think it's just a few MUMPS versions that people are interested in, and it's easy enough to type several version hashes into the JSON file. Thanks.

[eike-fokken]

Oh, cool! Thanks again for the prompt response!