No message when colors are NULL? about cowsay

[sckott]

fixed in #66

[aedobbyn]

Thanks, glad you like them!

This should be addressed in the latest PR:

cowsay::say("rms", "rms")
#> 
#> 
#>  ----- 
#> Behind Richard Stallman's beard there is another fist, to code faster. 
#>  ------ 
#>     \   
#>      \
#>                     @@@@@@ @
#>                   @@@@     @@
#>                  @@@@ =   =  @@ 
#>                 @@@ @ _   _   @@ 
#>                  @@@ @(0)|(0)  @@ 
#>                 @@@@   ~ | ~   @@
#>                 @@@ @  (o1o)    @@
#>                @@@    #######    @
#>                @@@   ##{+++}##   @@
#>               @@@@@ ## ##### ## @@@@
#>               @@@@@#############@@@@
#>              @@@@@@@###########@@@@@@
#>             @@@@@@@#############@@@@@
#>             @@@@@@@### ## ### ###@@@@
#>              @ @  @              @  @
#>                @                    @

Created on 2018-10-07 by the reprex
package (v0.2.0).

[maelle]

thank you! 😀

[sckott]

@aedobbyn makes sense to me to only throw the warning/message when a user does in fact supply color parameter values. what do you think?

[aedobbyn]

Ah yes, that's the perfect solution. Thanks @maelle!! If you'd like to submit the PR I'd say feel free -- otherwise I'm happy to do it.

[maelle]

I'd prefer you to 🙂 Thanks a ton! (And these color options are awesome!)