Comments (5)
the only way to do this is for the template used by the extended tests to not use an imagechangetrigger but instead to hardcode the image field in the DC.
which is not what we'd want for when the extended test is run in origin, since the purpose of that run is to, among other things, validate the template and the imagestream is part of that template.
so if we want reuse of the extended test between origin and here, we're kinda stuck at the moment.
from mongodb-container.
@bparees the replication example template doesn't include an image stream, it just points to the image openshift/mongo-24-centos7.
The config today executes:
# ...
vagrant test-origin-image --image mongodb --source openshift/$JOB_NAME --ref $ghprbActualCommit
# Run the "mongo" extended tests when comment contains [openshift]
if [[ "${ghprbCommentBody}" == *"[openshift]"* ]]; then
vagrant ssh -c "docker images"
vagrant test-origin --extended "core(mongo)" -d --skip-check --skip-image-cleanup
fi
# ...
IIRC vagrant test-origin-image
builds an image called openshift/mongo-24-centos7-candidate
. A quick fix would be to tag this image as openshift/mongo-24-centos7
, after vagrant test-origin-image
and before vagrant test-origin
.
WDYT?
from mongodb-container.
@rhcarvalho the make test job already includes the option to TAG_ON_SUCCESS=true, so if we just make sure that is set when we do the make test call, it sounds like we're fine?
from mongodb-container.
I didn't know about that tag, that should do it I suppose.
When the PR tester will be working again I could create a PR to ensure the tests break when they should.
from mongodb-container.
Currently it is possible to run test of replication in OpenShift by mentioning [test-openshift] (#222) in comment. This tests image which sources are in Pull Request.
So I hope this issue is fixed. (also there is new CI, so it is probably outdated)
Note: Adding new or extending current OpenShift testing scenarios can be done by modifying test/run-openshift
script in for example in 3.2/
folder.
from mongodb-container.
Related Issues (20)
- Create StatefulSet deployment for PostgreSQL HOT 2
- Replication support HOT 1
- erroneous error message when specifying admin password and a database name HOT 3
- Having an external route for mongo HOT 10
- Using this for production apps? HOT 5
- Deploying with glusterfs storage volume HOT 2
- run-mongod ignores rest of arguments HOT 1
- petset-replicas - unclear shutdown HOT 6
- Document how to back-up data from container HOT 2
- Provide example, test and doc for using own SSL cert HOT 1
- connecting as admin via gui HOT 2
- Support for journaling HOT 3
- Regression introduce with restarting slave pods with PVs HOT 3
- Publish Mongodb 4 image HOT 5
- First replica set member is not adding to existing replica set after failure HOT 5
- PVC with replicas HOT 2
- Exception in NodeJS app when new version deployed HOT 1
- OpenShift InstantiateTemplate is not generating admin password HOT 1
- MongoDB images newer than 3.6? HOT 2
- upgrade to v > 4.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mongodb-container.