GithubHelp home page GithubHelp logo

Comments (11)

scorchingoyster avatar scorchingoyster commented on August 30, 2024

I can give this a try and show you some examples.

Part of the challenge is that companies very often do not specify how the grey scale version of their logo might look like, or if they specify anything at all (and occasionally they would reach out to the site owner for getting it wrong, if it's a particularly big brand or the company has a highly conscious branding team).

The other aspect of this is that there are quite a variety of logo styles that I have seen for the members, most of which are flat-colored and should play nicely with that change, but it should be expected that some others would look a little off when given equal treatment.

from owasp-layout.

mikemccamon avatar mikemccamon commented on August 30, 2024

Agreed it can be an issue. In the past if a company complained about theirs, I just asked for a new version and 99% of the time that works.

from owasp-layout.

scorchingoyster avatar scorchingoyster commented on August 30, 2024

so I looked into it a bit, it seems like the best way to achieve this for the time being is to set aside two collections of logo images, grey scale for the list and color for the spotlight, because the CSS filter for non-SVG images has very limited support at the moment.

the other option is that we could consider using SVGs because it has almost universal image filter support, but about 30% of the logo files I found originally didn't come in SVG format (about half a dozen them I couldn't even find a good quality logo easily which I had to tweak it afterward), so that would mean I have to redraw ~20 of them for the time being as well as requiring this specific format in the future

let me know what you think—if we do plan to go with the former, I can just batch convert the existing set with a grey scale config... or, frankly, for the sake of ease of long-term management on your side, it might make sense to just stick with the color option.

from owasp-layout.

mikemccamon avatar mikemccamon commented on August 30, 2024

from owasp-layout.

scorchingoyster avatar scorchingoyster commented on August 30, 2024

the reason why I brought that up is because that I estimate it will take about 9-10 hours of time (mainly has to do with obscure logo fonts) to manually trace the ones without SVG format available online. I will be happy to do either, but I also know that you are concerned about time use, that's why I wanted to check with you first.

from owasp-layout.

mikemccamon avatar mikemccamon commented on August 30, 2024

from owasp-layout.

scorchingoyster avatar scorchingoyster commented on August 30, 2024

right, I agree!

also, I tried a couple of batch gray scale conversion, let's just say they all don't look very good because the base color doesn't translate well directly into grey with a set parameter—so to say, it requires manual tweaking of each image to get the color -> grey scale look decent, see below:

image

my verdict is that we stick with the color logos for now because all of the available options either don't work very well or will end up taking a lot of time.

from owasp-layout.

mikemccamon avatar mikemccamon commented on August 30, 2024

from owasp-layout.

scorchingoyster avatar scorchingoyster commented on August 30, 2024

either a SVG or PNG would work, since we need the transparency, JPG won't fit the criteria.

the larger corporations should have a version of that ready, but smaller companies might not.

actually, let me just manually convert each one, I tried doing 2-3 in Photoshop just now and it seems it takes 1~2min top for each one, which should take about +/- an hour to get them done by hand. it looks much better than batch conversion or done outside of Photoshop.

from owasp-layout.

scorchingoyster avatar scorchingoyster commented on August 30, 2024

it's actually a little faster than I thought, only took 30min and I am half-way through; I had to tweak specific ones or find a different version online but most were straightforward

image

from owasp-layout.

scorchingoyster avatar scorchingoyster commented on August 30, 2024

took a little over an hour and a half, but the members list is now in full grey scale on live. also added a lighten hover interaction.

I did have to custom darken about half them since the originals were so light when they are converted.

from owasp-layout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.