Comments (7)
@zzxoto This is a really good in-depth guide of how to properly do pull requests.
https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github
(Before I never forked, so sometimes other people's changes to the original repo would trickle down to mine.)
from how-many-days-until-halloween.
Hey @scrabill ,
Please check and approve this PR [https://github.com//pull/103]
Thanks Again!
- Gautam Mandsorwale
from how-many-days-until-halloween.
@GautamMandsorwale @mtrunt - Your additions have been merged!
from how-many-days-until-halloween.
I'll also add a spooky line.
EDIT: Pull request opened - splashText is shaping up to be a nice Halloween poem!
from how-many-days-until-halloween.
Hey I have never done collaboration on GIT. I have a question. So, I make some changes and push the changes to my remote repo. Then how would that get merged into this repo? Correct me if I am wrong but I have a feeling that its has got to do with pull request. How does that work. Can some one give me full process of how the whole contribution scheme works.
from how-many-days-until-halloween.
Hi @scrabill,
Please see and review my Pull Request for this Issue here.
Happy Halloween! 👻
from how-many-days-until-halloween.
Hi @scrabill ,
Thanks for creating this.
Here is my first ever Git Pull request.
Please review this.
from how-many-days-until-halloween.
Related Issues (20)
- Documentation: Remove "fonts folder" link from CONTRIBUTING.md HOT 5
- Enhancement: Add Fork me on Github Ribbon OR Github Corner HOT 1
- Bug: Countdown logic is off by 1 HOT 1
- Enhancement: Add a Halloween fact HOT 2
- Documentation: Refactor styles.css HOT 2
- Enhancement: Add Halloween Costume Ideas HOT 3
- The Website Isn't Up-To-Date HOT 2
- BugFix: Fix a typography error in the website's footer HOT 3
- Enhancement: Migrate the facts and costumes array to different javascript files HOT 2
- Update Mobile Styling HOT 4
- Add License HOT 3
- Update contributing document HOT 6
- Clarify contributing instructions HOT 2
- Adding icon logo in title bar
- Add grid image HOT 3
- Working on issue #361 HOT 2
- A special message on Friday the 13th? HOT 4
- The text in website is aligned towards left. It will looks more better in centre. HOT 1
- Collaborative story? HOT 2
- Consider using flexbox or grid for alignment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from how-many-days-until-halloween.