GithubHelp home page GithubHelp logo

Comments (7)

adityas114 avatar adityas114 commented on September 16, 2024 2

Hi, I would like to work on this. It would be great if you can assign me the issue.

I am thinking when the parsed output is returned from rdflib in rdfa.py, we can use the document object to fix the order in extruct itself. I have started working on it and I can raise a pull request soon.

from extruct.

ivanprado avatar ivanprado commented on September 16, 2024 1

@croqaz the order is important for values. Usually, some pages annotate several images but the most important one (the one with the biggest resolution or more relevant) is the first one. If a set is used the order is lost. Instead, it would better to get consistent ordering by having values in the order they appear in the page. That's unfortunately not the case for RDFa.

from extruct.

croqaz avatar croqaz commented on September 16, 2024 1

Thank you for the explanation @ivanprado 👍

from extruct.

kmike avatar kmike commented on September 16, 2024

fwiw, extruct is using https://github.com/RDFLib/rdflib, not pyRdfa. This could be related (not 100% sure): RDFLib/rdflib#538.

from extruct.

croqaz avatar croqaz commented on September 16, 2024

What would be the implications to use SET instead or LIST in the RDFa values?
Eg: The values would be converted to sets of frozen Dicts:

"http://ogp.me/ns#image": [
                {
                    "@value": "http://images.sk-static.com/images/media/img/col4/20100330-103600-169450.jpg"
                },
                {
                    "@value": "http://images.sk-static.com/SECONDARY_IMAGE.jpg"
                }
            ],

from extruct.

ivanprado avatar ivanprado commented on September 16, 2024

Hi @adityas114 . Nice if you can work on it 👍 . In order to contribute, just create a PR with the fix. There is no need to assign the issue.

from extruct.

adityas114 avatar adityas114 commented on September 16, 2024

@ivanprado I have created a PR (#139) for this issue. Please have a look and let me know if it requires any changes.

from extruct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.