Comments (7)
Hi, I would like to work on this. It would be great if you can assign me the issue.
I am thinking when the parsed output is returned from rdflib in rdfa.py, we can use the document object to fix the order in extruct itself. I have started working on it and I can raise a pull request soon.
from extruct.
@croqaz the order is important for values. Usually, some pages annotate several images but the most important one (the one with the biggest resolution or more relevant) is the first one. If a set is used the order is lost. Instead, it would better to get consistent ordering by having values in the order they appear in the page. That's unfortunately not the case for RDFa.
from extruct.
Thank you for the explanation @ivanprado 👍
from extruct.
fwiw, extruct is using https://github.com/RDFLib/rdflib, not pyRdfa. This could be related (not 100% sure): RDFLib/rdflib#538.
from extruct.
What would be the implications to use SET instead or LIST in the RDFa values?
Eg: The values would be converted to sets of frozen Dicts:
"http://ogp.me/ns#image": [
{
"@value": "http://images.sk-static.com/images/media/img/col4/20100330-103600-169450.jpg"
},
{
"@value": "http://images.sk-static.com/SECONDARY_IMAGE.jpg"
}
],
from extruct.
Hi @adityas114 . Nice if you can work on it 👍 . In order to contribute, just create a PR with the fix. There is no need to assign the issue.
from extruct.
@ivanprado I have created a PR (#139) for this issue. Please have a look and let me know if it requires any changes.
from extruct.
Related Issues (20)
- Some websites put meta tags outside the head. HOT 2
- Very slow extraction for specific string HOT 6
- LD+JSON outside HTML element HOT 1
- error extracting json-ld for validated json
- [suggestion] adding type hints? HOT 7
- Should not Depends on python3 (<< 3.7) HOT 6
- lxml.etree.ParserError: Document is empty HOT 5
- " in application/ld+json gives exception
- Consider switching from lxml's clean_html for enhanced security (and possibly performance) HOT 7
- Selectolax benchmarks
- Unable to get meta tag value from inside body
- SyntaxWarning invalid escape sequence '\s'
- Package breaking due to change in lxml HOT 2
- ImportError: cannot import name '_ElementStringResult' from 'lxml.etree' HOT 1
- chore: Remove Python 2 specific code
- feat: Add dependabot for github actions HOT 3
- cannot import name '_ElementStringResult' from 'lxml.etree HOT 2
- Latest release on PyPi (0.16.0) breaks with lxml>5.1.0: import extruct throws ImportError: cannot import name '_ElementStringResult' HOT 1
- Installing with lxml-5.2.1 ImportError: cannot import name '_ElementStringResult' from 'lxml.etree' HOT 3
- Fix the Build Status badge
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from extruct.