Comments (13)
@WorldLanguages Yes, I loaded the extension some time ago. (I downloaded the repository as ZIP, which works too)
from scratchaddons.
We need to include any 3rd party libraries inside the extension's source code to avoid potential remote code execution. The CSP will stay as is, @BoomerScratch.
from scratchaddons.
//cc @WorldLanguages They still don't work. It requires other iconify scripts.
from scratchaddons.
Hmm, I'll take a look at this later.
from scratchaddons.
In my opinion, it is easier to just download all the required icons locally and use them without any dependencies
from scratchaddons.
@GrahamSH-LLK I'm not getting any errors, can you explain?
from scratchaddons.
Looks like iconify's script also loads scripts by itself, so it's still broken
from scratchaddons.
We have two options:
- Remove CSP (Yes, I know about #56 (comment))
- Remove Iconify
from scratchaddons.
@BoomerScratch he default CSP is stricter than the current one! Not specifying a CSP doesn't mean there's not one.
@GDUcrash will work on this soon. Don't worry about it.
Btw I'm currently making many changes rn so avoid working on the repo
from scratchaddons.
@WorldLanguages Maybe we can disable the CSP only on the options page?
from scratchaddons.
@BoomerScratch Nope that's not possible. Don't worry about it.
from scratchaddons.
@WorldLanguages #82 fixed this, right?
from scratchaddons.
@BoomerScratch No, remember I said below, the default CSP is stricter than the one I previously specified. Now with no specified CSP it doesn't mean there's no CSP, it just fallbacks to the default one. The default one doesn't allow remote scripts either. And allowing remote scripts is simply a bad idea. Don't worry, we'll just download the icons as SVGs and include them with the extension. Expect updates soon.
Also, have you tried testing out the extension? Simply clone it, enable developer mode on chrome://extensions, load the folder as an unpacked extension and you should be able to check the console errors in the settings page.
from scratchaddons.
Related Issues (20)
- Global Custom Blocks/Procedures HOT 14
- “HD Image Uploads” is exceedingly slow with modified stage size on Safari HOT 3
- ocular addon should respect theme choice HOT 1
- Revisit CWS privacy information
- Permissions page should not be opened by settings-popup to avoid duplication HOT 1
- Filter backpack by category (sprite, script, etc.) or name of the thing
- Multicolored Comments HOT 16
- custom block shape new preset HOT 5
- `old-studio-layout`: "You will be able to edit studios again (...)" modal is oversized on titles HOT 2
- i dont know its cratches fault or this HOT 3
- Webpage Creation HOT 2
- Addons taking a moment to activate if it has been > 30 seconds since last Scratch page visit HOT 9
- `numberpad` + `mediarecorder`: Numberpad clips onto mediarecorder HOT 1
- new addon: fix small stage affecting project page (or switch to large stage before going to project page)
- Addons don't work when running scratch-www locally HOT 4
- Run on `localhost:8602` HOT 3
- Markdown in comment HOT 2
- Revamp `mediarecorder`'s "Start Recording" modal
- Doesn't work on Android Firefox since the recent update HOT 7
- `mediarecorder`: custom shortcut to stop- and start recording HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scratchaddons.