GithubHelp home page GithubHelp logo

Comments (13)

BoomerScratch avatar BoomerScratch commented on May 31, 2024 1

@WorldLanguages Yes, I loaded the extension some time ago. (I downloaded the repository as ZIP, which works too)

from scratchaddons.

WorldLanguages avatar WorldLanguages commented on May 31, 2024

We need to include any 3rd party libraries inside the extension's source code to avoid potential remote code execution. The CSP will stay as is, @BoomerScratch.

from scratchaddons.

GrahamSH-LLK avatar GrahamSH-LLK commented on May 31, 2024

//cc @WorldLanguages They still don't work. It requires other iconify scripts.

from scratchaddons.

WorldLanguages avatar WorldLanguages commented on May 31, 2024

Hmm, I'll take a look at this later.

from scratchaddons.

GDUcrash avatar GDUcrash commented on May 31, 2024

In my opinion, it is easier to just download all the required icons locally and use them without any dependencies

from scratchaddons.

BoomerScratch avatar BoomerScratch commented on May 31, 2024

@GrahamSH-LLK I'm not getting any errors, can you explain?

from scratchaddons.

WorldLanguages avatar WorldLanguages commented on May 31, 2024

Looks like iconify's script also loads scripts by itself, so it's still broken

from scratchaddons.

BoomerScratch avatar BoomerScratch commented on May 31, 2024

We have two options:

from scratchaddons.

WorldLanguages avatar WorldLanguages commented on May 31, 2024

@BoomerScratch he default CSP is stricter than the current one! Not specifying a CSP doesn't mean there's not one.
@GDUcrash will work on this soon. Don't worry about it.
Btw I'm currently making many changes rn so avoid working on the repo

from scratchaddons.

BoomerScratch avatar BoomerScratch commented on May 31, 2024

@WorldLanguages Maybe we can disable the CSP only on the options page?

from scratchaddons.

WorldLanguages avatar WorldLanguages commented on May 31, 2024

@BoomerScratch Nope that's not possible. Don't worry about it.

from scratchaddons.

BoomerScratch avatar BoomerScratch commented on May 31, 2024

@WorldLanguages #82 fixed this, right?

from scratchaddons.

WorldLanguages avatar WorldLanguages commented on May 31, 2024

@BoomerScratch No, remember I said below, the default CSP is stricter than the one I previously specified. Now with no specified CSP it doesn't mean there's no CSP, it just fallbacks to the default one. The default one doesn't allow remote scripts either. And allowing remote scripts is simply a bad idea. Don't worry, we'll just download the icons as SVGs and include them with the extension. Expect updates soon.
Also, have you tried testing out the extension? Simply clone it, enable developer mode on chrome://extensions, load the folder as an unpacked extension and you should be able to check the console errors in the settings page.

from scratchaddons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.