Comments (15)
The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.
Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match.
It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....
from scratchaddons.
My expectation here is that the add-on is supposed to know the existence of the sprites inside the closed folders. I am aware that the issue is caused by the folders being treated as sprites. The reason why we should be able to search for sprites inside closed folders is because that way, we can instantly locate the sprites without having to plow through the folders we have created.
from scratchaddons.
It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.
At least on Windows, searching in a folder includes all subfolders. I think users will expect a similar behavior here.
from scratchaddons.
What about the following fix:
When the user searches for a sprite by name...
- Remember which folders are opened and which ones are closed
- Open all folders
- Search for the sprite
When the search is cleared, close the folders that were closed before the search.
from scratchaddons.
It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.
from scratchaddons.
It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.
At least on Windows, searching in a folder includes all subfolders. I think users will expect a similar behavior here.
Yes, indeed we can search for subfolders in a folder... And we can search folders here?
from scratchaddons.
The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.
Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match.
from scratchaddons.
It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....
But then you have to, before your search, open all the folders you want to search in.
I think it should always show folders if their name or a name of a sprite inside of them matches the search query, regardless of if they're opened or closed.
from scratchaddons.
The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.
Folder closed: Folder opened:
Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match.It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....
If we weren't able to search for contents of closed folders, we would have to open EVERY folders in able to search for all sprites, by the time we would have already located where the sprite was.
By the way, the addon could do well with an option to open or close every folders.
from scratchaddons.
Related Issues (20)
- `fullscreen` + `editor-compact`: Projects exit fullscreen on load HOT 1
- Draggable toggle HOT 6
- Accessibility issues in category tabs HOT 6
- Showing an insertion marker for block snapping HOT 2
- Open 500x500 image by clicking profile picture HOT 4
- Hide-flyout addon improvement HOT 2
- `hide-backpack` + `custom-zoom` (auto hide zoom) : Cannot zoom in with button due to offset HOT 5
- `forum-search` shouldn't have to push the content down when the search bar appears
- `gamepad`: Popup when rebinding controls HOT 1
- Hold the middle mouse button and drag to pan the costume editor canvas HOT 1
- What to do for April Fools 2024? HOT 17
- `download-button`: Spinner color should adapt to button background HOT 2
- New Addon: Make mentions clickable in messages. HOT 6
- Backspace delete and backslash switch to local sprite variable / switch to global variable HOT 10
- Hide-flyout addon bug HOT 1
- New addon: show more costumes in assets list, more than one column HOT 13
- h1 border goes into the logo in README HOT 9
- Downloading a sprite in a folder and uploading it somewhere else creates that folder there. HOT 5
- Data Category Tweaks no longer working! HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scratchaddons.