GithubHelp home page GithubHelp logo

Comments (15)

Waakul avatar Waakul commented on June 12, 2024 4

The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.

Sprites called "In folder 1" and "In folder 2" in a folder called "Folder", and two sprites "Not in fold..." not in that folder. Folder closed: Two sprites called "Not in fold..." while "in fo" is being searched for Folder opened: Sprites called "In folder 1" and "In folder 2" in a folder, and two sprites "Not in fold..." not in that folder, while "in fol" is being searched for. The folder is not visible.

Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match. Two sprites called "Not in fold..." while "fol" is being searched for. Additionally, there's an opened folder called "Folder" that doesn't have any contents.

It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....

from scratchaddons.

windsoryeh avatar windsoryeh commented on June 12, 2024 4

My expectation here is that the add-on is supposed to know the existence of the sprites inside the closed folders. I am aware that the issue is caused by the folders being treated as sprites. The reason why we should be able to search for sprites inside closed folders is because that way, we can instantly locate the sprites without having to plow through the folders we have created.

from scratchaddons.

mxmou avatar mxmou commented on June 12, 2024 2

It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.

At least on Windows, searching in a folder includes all subfolders. I think users will expect a similar behavior here.

from scratchaddons.

iqnite avatar iqnite commented on June 12, 2024 2

What about the following fix:
When the user searches for a sprite by name...

  1. Remember which folders are opened and which ones are closed
  2. Open all folders
  3. Search for the sprite
    When the search is cleared, close the folders that were closed before the search.

from scratchaddons.

Waakul avatar Waakul commented on June 12, 2024 1

It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.

from scratchaddons.

Waakul avatar Waakul commented on June 12, 2024

It is working as it is supposed to be, to search in a folder you're supposed to open it. Think about how folders and files work on your computer.

At least on Windows, searching in a folder includes all subfolders. I think users will expect a similar behavior here.

Yes, indeed we can search for subfolders in a folder... And we can search folders here?

from scratchaddons.

mybearworld avatar mybearworld commented on June 12, 2024

The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.

Sprites called "In folder 1" and "In folder 2" in a folder called "Folder", and two sprites "Not in fold..." not in that folder.
Folder closed:
Two sprites called "Not in fold..." while "in fo" is being searched for
Folder opened:
Sprites called "In folder 1" and "In folder 2" in a folder, and two sprites "Not in fold..." not in that folder, while "in fol" is being searched for. The folder is not visible.

Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match.
Two sprites called "Not in fold..." while "fol" is being searched for. Additionally, there's an opened folder called "Folder" that doesn't have any contents.

from scratchaddons.

mybearworld avatar mybearworld commented on June 12, 2024

It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....

But then you have to, before your search, open all the folders you want to search in.

I think it should always show folders if their name or a name of a sprite inside of them matches the search query, regardless of if they're opened or closed.

from scratchaddons.

windsoryeh avatar windsoryeh commented on June 12, 2024

The issue here seems to be that folders are treated just like sprites. When the folder is closed, the sprites in that folder are not considered to exist.
Sprites called "In folder 1" and "In folder 2" in a folder called "Folder", and two sprites "Not in fold..." not in that folder. Folder closed: Two sprites called "Not in fold..." while "in fo" is being searched for Folder opened: Sprites called "In folder 1" and "In folder 2" in a folder, and two sprites "Not in fold..." not in that folder, while "in fol" is being searched for. The folder is not visible.
Here, the two sprites in the folder were renamed to "In 1" and "In 2", so the query doesn't match. Two sprites called "Not in fold..." while "fol" is being searched for. Additionally, there's an opened folder called "Folder" that doesn't have any contents.

It's supposed to act like that tbh. if the folder is closed, it's not supposed to display sprites inside that....

If we weren't able to search for contents of closed folders, we would have to open EVERY folders in able to search for all sprites, by the time we would have already located where the sprite was.
By the way, the addon could do well with an option to open or close every folders.

from scratchaddons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.