GithubHelp home page GithubHelp logo

Comments (2)

jayvdb avatar jayvdb commented on July 16, 2024

ping @frostming , can you confirm you are the author of this?

I've confirmed this patch is needed by pipenv.

Without it, test_uninstall.py::test_normalize_name_uninstall fails at assert "# Inline comment" in contents, with the entire line removed.

Now I understand the patches effect a bit better, this feels like it isnt a complete patch, as that inline comment after an entry probably needs to be removed with the entry in some cases, and it should be up to the caller whether 'dangling' comments should be kept, so some mechanism needs to be added to allow the caller to control this. But that is just a guess, and I'd appreciate feedback from @sdispater about whether this patch is acceptable as-is .

from tomlkit.

frostming avatar frostming commented on July 16, 2024

this patch is authored by me to preserve the comment when an entry is removed. It is required by pipenv in the regressiin cases. However it is not always expected
for a general toml document. Cases are user may want to remove the comments together with the line it is bound to. So I just patch it in pipenv vendor but leave it to original creator how to design it.

from tomlkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.