GithubHelp home page GithubHelp logo

Comments (2)

csala avatar csala commented on May 10, 2024

Thanks for the suggestion, @kevinykuo , but I'm afraid I disagree with this.

The rationale behind the parameter organization is:

  • __init__ arguments specify "how" this instance is going to behave, i.e. "how" this model will learn.
  • fit arguments specify "on which data".

The only argument that could be moved to the fit method is epochs, and only the code is changed so the creation of the internal instances is not done every time the fit method is executed, which would then allow resuming a previous fitting process (see #4 )

All the other arguments are fine where they are and should be kept there.

from ctgan.

kevinykuo avatar kevinykuo commented on May 10, 2024

Thanks @csala! I think your comments make sense. A couple of use cases (neither of which hits me currently) that may benefit from moving batch_size are 1) one may want to continue training a model on a different machine that doesn't enough GPU memory to support the batch size specified and 2) adaptive batch sizes. This is pretty minor though, so no hearts be broken by a wontfix :)

from ctgan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.