Comments (2)
Thanks for the suggestion, @kevinykuo , but I'm afraid I disagree with this.
The rationale behind the parameter organization is:
__init__
arguments specify "how" this instance is going to behave, i.e. "how" this model will learn.fit
arguments specify "on which data".
The only argument that could be moved to the fit
method is epochs
, and only the code is changed so the creation of the internal instances is not done every time the fit
method is executed, which would then allow resuming a previous fitting process (see #4 )
All the other arguments are fine where they are and should be kept there.
from ctgan.
Thanks @csala! I think your comments make sense. A couple of use cases (neither of which hits me currently) that may benefit from moving batch_size
are 1) one may want to continue training a model on a different machine that doesn't enough GPU memory to support the batch size specified and 2) adaptive batch sizes. This is pretty minor though, so no hearts be broken by a wontfix :)
from ctgan.
Related Issues (20)
- Tune about CTGAN
- TypeError while ctgan.fit() HOT 6
- Improve DataSampler efficiency
- ValueError: mismatch of shapes when sampling data for compas dataset HOT 2
- Return loss values as float values not PyTorch objects
- Transition from using setup.py to pyproject.toml to specify project metadata
- Remove bumpversion and use bump-my-version
- Switch to using ruff for Python linting and code formatting
- Add dependency checker
- Remove scikit-learn dependency
- CTGAN using deprecated 'sklearn' HOT 2
- Replace integration test that uses the iris demo data
- Add bandit workflow
- Feature Request: More verbose logging HOT 3
- Fix minimum version workflow when pointing to github branch
- Deployment requirements based on libtorch or onnx๏ผ HOT 1
- How to load this model directly to generate data after saving it HOT 4
- Cleanup automated PR workflows
- Remove FutureWarning: Setting an item of incompatible dtype is deprecated
- Only run unit and integration tests on oldest and latest python versions for macos
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ctgan.