Proto-bootstrap scripts for HAX about cortx-hare

[andriytk]

closed

[andriytk]

I don't think we need such a script specifically for hax. It can be started via systemctl start hax command now.

[typeundefined]

The file is generated like this: pylint --generate-rcfile >./.pylintrc

But please note that I've already put some changes there (and there are some things yet to be polished):

63,64c63,64
< disable=missing-docstring,
<         print-statement,
---
> disable=print-statement,
>         C0111,

C0111 is explained here

[vvv]

assigned to @andriy.tkachuk

[vvv]

assigned to @konstantin.nekrasov

[vvv]

added 1 commit

• a06053c9 - Rename startup.sh -> start

Compare with previous version

[vvv]

changed this line in version 3 of the diff

[vvv]

changed this line in version 3 of the diff

[vvv]

changed this line in version 3 of the diff

[vvv]

changed this line in version 3 of the diff

[vvv]

changed this line in version 3 of the diff

[vvv]

changed this line in version 3 of the diff

[vvv]

@andriy.tkachuk Would you write the patch please?

[vvv]

Please use single quotes unless there is an expression to expand. See https://github.com/bahamas10/bash-style-guide#quoting . (Yes, I promise to post a MR with coding style today. My apologies.)

[vvv]

set -eu -o pipefail
# set -x
export PS4='+ [${FUNCNAME[0]:+${FUNCNAME[0]}:}${LINENO}] '

Rationale:

• The Rule of Silence.
• set -x on a separate line is easy to uncomment.
• This value of PS4 shows function name and line number in set -x output.

See also h0 script.

[vvv]

1. Please rename to M0_SRC_DIR — the name used in Mero, Halon, and Hare code.
2. We should honour the value of M0_SRC_DIR coming from environment:

M0_SRC_DIR=${M0_SRC_DIR:-${SRC_DIR%/*}/mero}

[vvv]

Please use

SRC_DIR="$(dirname $(readlink -f $0))"

See the output of git grep -nH readlink.

[vvv]

How does .env file appear?

[vvv]

Where does .pylintrc originate from?

[andriytk]

systemctl start consul-agent ?

You just have to register systemd/consul-agent.service beforehand.

[typeundefined]

changed the description

[typeundefined]

mentioned in issue #84

[typeundefined]

added 1 commit

• 0363066e - Remove redundant comment

Compare with previous version