Error for sqlx_migrations table when generating entities about sea-orm

[billy1624]

Hey @heliumbrain, I have published the fix. Please run cargo install sea-orm-cli to update the CLI.

[tyt2y3]

I think we don't need to overdo it for now.
Ignoring _ prefix tables is a reasonable behaviour.
At most add an 'include-hidden-tables' option is fine.

[billy1624]

Hi @heliumbrain, nice catch!

[tyt2y3]

But I guess it's better for us to simply ignore table names starting with underscore

[billy1624]

But I guess it's better for us to simply ignore table names starting with underscore

The CLI will generate an entity file named sqlx_migrations.rs for _sqlx_migrations table, with

//! src/entity/sqlx_migrations.rs
impl EntityName for Entity {
  fn table_name(&self) -> &str {
    "_sqlx_migrations"
  }
}

Together with,

//! src/entity/mod.rs
pub mod sqlx_migrations;

//! src/entity/prelude.rs
pub use super::sqlx_migrations::Entity as SqlxMigrations;

[tyt2y3]

Yes but that's not what users want typically.

[billy1624]

You mean we should skip all tables names starting with underscore?

i.e. not generating entity files for these tables

[tyt2y3]

Yes that's what I meant.

[billy1624]

Perhaps we can add an ignore option?

sea-orm-cli generate entity --ignore '^_'

With default value ^_.

Users can choose to override it by providing an empty regex expression, i.e.

sea-orm-cli generate entity --ignore ''

Or, it would be better to explicitly disable it?

sea-orm-cli generate entity --no-ignore

[billy1624]

I think we don't need to overdo it for now.
Ignoring _ prefix tables is a reasonable behaviour.
At most add an 'include-hidden-tables' option is fine.

We can merge the PR then implement the new behavior