When using "who-calls" and selecting an item, one should go to where the function is called, not to the first definition of the calling function about edts

[SpaceOgre]

This has bugged me a bit to and I have done a fast fix that looks like this:

(defun edts-find-callers (module function arity)
  "Jump to any all functions calling `module':`function'/`arity' in the
current buffer's project."
  (edts-log-info "Finding callers of %s:%s/%s" module function arity)
  (let* ((callers (edts-get-who-calls module function arity))
         (caller-items (mapcar #'edts-function-popup-item callers)))
    (edts-do-find-callers caller-items)
    (edts-find-first-apperence-in-fun module function)))

(defun edts-find-first-apperence-in-fun (module function)
  (let ((cur-module (ferl-get-module))
        (mark  (copy-marker (point-marker)))
        (re (if (string-equal module cur-module)
                function
              (concat module ":" function))))
    (if (re-search-forward re nil t)
        (progn
          (beginning-of-line)
          (ring-insert-at-beginning (edts-window-history-ring) mark))
      (null (goto-char mark)))))

I'm far from a lisp expert so there is probably a better a more accurate way to do it but it's a start.

• edts-find-first-apperence-in-fun is a new function
• edts-find-callers is modified to call edts-find-first-apperence-in-fun
  It just searches for the first appearance of module:function after the point of the calling function head. Regexp needs to better so not comments etc are chosen.

[tjarvstrand]

Actually having looked at it, it's pretty straight forward to get this information straight out of xref. I just need to update the api a little. I'll try to get to it since I'm currently rewiring all of the xref code anyway.

[tjarvstrand]

Sometimes things are really easy. The fix is in master now.

[SpaceOgre]

Nice! I started to look at the server code but since I have never used xref before I hit a wall with that, but it felt like that was to place to really change and not my fast hack.

Keep up the good work, I use edts every day for work and it just keeps getting better 👍