Comments (12)
Thanks for the report. I'm aware of the issue, and it's very annoying indeed. It's due to the fact that eproject contains a definition for a basic git-project which will be preferred over edts if it is further up in the file tree. I have been thinking about how to solve this for a while but I haven't yet found a satisfying solution that can either be incorporated into edts without forking eproject or that will be accepted into upstream eproject :( Any ideas would be very welcome.
from edts.
Actually I think I might have an acceptable solution for this. Will look into it when I get back from vacation.
from edts.
Awesome! Great work, Thomas!
from edts.
I believe this should now be fixed. The fix is slightly hackish but seems to work :)
Please re-open this issue if your problems persist.
from edts.
Did you forget to push? :) I don't see the fix in current master
from edts.
Yup it's right there. The relevant code is in edts-setup and edts-project-selector.
There's even an integration test called edts-project-selector-test.
Are you experiencing problems with it?
from edts.
Reverting 5dcb9ab fixes things for me and project is properly picked up as edts, otherwise it's incorrectly identified as generic-git. Funny that eproject-project-type has overridden values, and (eproject--all-types) returns:(edts-temp edts-otp edts generic).
Value of eproject-attributes-alist:
(("/home/mborzecki/work/test.project/" :type generic-git :name "test.project" :irrelevant-files ("^[.]" "^[#]" ".git/") :relevant-files (".*") :irrelevant-files ("^[.]" "^[#]") :file-name-map ...))
Seems like eproject hooks are run before erlang-mode hooks.
Emacs version: GNU Emacs 24.3.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.8.2) of 2013-08-14 on buildvm-15.phx2.fedoraproject.org
from edts.
Will try to look into this tonight.
from edts.
@bboozzoo
Could you try with the branch advice-to-limit-project-types and see if that works for you?
from edts.
I think that fed315f is bad. All projects will be classified as edts-temp as it appears as a last entry and all project definitions have same list of relevant files.
There's something weird going on. If project directory has dots (ex. some.test.project) then .edts is not loaded, project is incorrectly classified as generic-git and erlang node cannot be started. Removing the dots, the problem disappears.
from edts.
If that commit is in your history you're on the wrong branch :)
from edts.
Thomas Järvstrand writes:
You're on the wrong branch :)
True. It works now. Project type is correct, .edts was picked up, node
name is correct and node is up and running.
Thanks!
Maciek Borzęcki
from edts.
Related Issues (20)
- eproject: invalid-read-syntax HOT 3
- Does the OTP release of the EDTS node and the project node need to be the same? HOT 5
- Merging with OTP? HOT 4
- Starting node fails HOT 7
- How to run EDTS when the R19 patches haven't been merged HOT 1
- error on beam file without outdir in compile options not compiled in ebin directory HOT 1
- Command to compile current module in edts-shell HOT 8
- Windows: Could not start main server HOT 2
- project node constantly being reinitialized for each newly opened file HOT 4
- rebar3 mode for filename_to_outdir HOT 1
- EDTS Erlang files are not compiled as part of package installation HOT 4
- How to start edts with many user in 1 machine? HOT 1
- Symbol's value as variable is void: erlang-operators-regexp HOT 3
- EDTS sub package meck fails to compile on OTP 21 HOT 3
- EDTS stopped working when upgrading to OTP21 HOT 2
- edts-20200209.1523 work fail HOT 2
- When compiling MELPA package: can't find include file "otp_workarounds.hrl" HOT 1
- edts-rpc-port hardcoded to 4587
- edts-plugin-disabled-plugins default value and type mismatch HOT 2
- {error,"Release \"edts\" uses non existing application mochiweb"} HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edts.