GithubHelp home page GithubHelp logo

Comments (7)

Sebclem avatar Sebclem commented on May 25, 2024 1

I'm working on a major rewrite that will fix this issue, you can see what's planed in #192

from hassio-nextcloud-backup.

Sebclem avatar Sebclem commented on May 25, 2024

A partial snapshot with everything selected is exactly the same as a full snapshot.

The only things that differ is the API endpoint used :
/snapshots/new/full for full
/snapshots/new/partial for partial

I can add a check, if everything is selected, use /snapshots/new/full instead of /snapshots/new/partial, but this is only a aesthetic/naming issue, as the 2 type generated file are the same if we exclude none of the folders/addons

from hassio-nextcloud-backup.

vincegre avatar vincegre commented on May 25, 2024

A partial snapshot with everything selected is exactly the same as a full snapshot.

Fully agree on that but it's making it pretty confusing to know which backups are full or partial as they all appear as partial ;)

I can add a check, if everything is selected, use /snapshots/new/full instead of /snapshots/new/partial, but this is only a aesthetic/naming issue, as the 2 type generated file are the same if we exclude none of the folders/addons

Hum I would have an other suggestion that would avoid also a drawback of your plugin. Instead of having to select everything, make it either full snapshot and then use the full api endpoint or manual as it is now where you tick/untick what you want and then select partial api endpoint ! It would avoid a big issue of your plugin right now: if I add a new plugin in hassio and don't go back in the backup plugin to tick that new plugin it'll be never backuped...

Side note: it's really a great plugin you made there and love it ;) If I can help for translation or whatever would be happy too ;)

from hassio-nextcloud-backup.

stale avatar stale commented on May 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from hassio-nextcloud-backup.

tomershvueli avatar tomershvueli commented on May 25, 2024

I'm seeing this issue as well. Would be to have full backups actually show up as 'full'. The 'partial' gave me half a heart attack before I started reading into it...

from hassio-nextcloud-backup.

vincegre avatar vincegre commented on May 25, 2024

Any chance to get it fixed at a time ? 

from hassio-nextcloud-backup.

vincegre avatar vincegre commented on May 25, 2024

I'm working on a major rewrite that will fix this issue, you can see what's planed in #192

Thanks for the update and that's really nice :) impatient to be able to test the completely rewritten version of the add-on ;) Good luck !

from hassio-nextcloud-backup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.