Snapshot show up as protected without using a password about hassio-nextcloud-backup

[Sebclem]

Did the you turn off the password protected switch ? (Just on top of the password field)
With this switch off I have all my backup as expected (protected=flase)

But I will add a check to prevent issue : if password protected is on, check is password is not empty.

I will add this as soon as I can, I'm a little busy this month.

[chanz]

Well currently my settings look like in the following screenshot. But well Snapshots still show up as protected and I can't restore them.

[Sebclem]

Very strange, I will try to get some time tomorrow to dig into this issue (It's 1:00AM here 😅)
But my first idea a corrupted setting file but I don't know how it's possible.
I will dig into this.

[chanz]

Thank you very much. Let me know if I can provide any thing else.

[Sebclem]

Do you have any warning in the addon logs when you save the config ?

[chanz]

With loglevel info I just see the following, when saving the settings:

[2021-06-08 00:24:45] [info]: 	Stopping Cron...
[2021-06-08 00:24:45] [info]: 	Starting Cron...

Using debug I can see the following:

[2021-06-08 00:26:44] [debug]: 	exclude_folder is not array (Empty value), reset...
[2021-06-08 00:26:44] [debug]: 	exclude_addon is not array (Empty value), reset...
[2021-06-08 00:26:44] [info]: 	Stopping Cron...
[2021-06-08 00:26:44] [info]: 	Starting Cron...

To test it more, I turned password protection on. But the settings page sometimes forgets my password and turns password protection off. I try to find a cause for you to reproduce, but found nothing so far.

This is the full log of restarting the addon, saving its settings and starting a backup/snapshot:

[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] 10-run: applying... 
[fix-attrs.d] 10-run: exited 1.
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 00-banner.sh: executing... 
-----------------------------------------------------------
 Add-on: Nextcloud Backup
 Easily backup your Home Assistant snapshots to Nextcloud
-----------------------------------------------------------
 Add-on version: 0.16.1
 You are running the latest version of this add-on.
 System: Home Assistant OS 5.13  (aarch64 / raspberrypi4-64)
 Home Assistant Core: 2021.5.5
 Home Assistant Supervisor: 2021.05.4
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
[cont-init.d] 00-banner.sh: exited 0.
[cont-init.d] 01-log-level.sh: executing... 
Log level is set to DEBUG
[cont-init.d] 01-log-level.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
[00:33:29] INFO: Starting Node...
> [email protected] start /opt/nextcloud_backup
> node ./bin/www 
[2021-06-08 00:33:32] [info]: 	Satus : Go !
[2021-06-08 00:33:32] [info]: 	Initializing and checking webdav client...
[2021-06-08 00:33:32] [info]: 	Starting auto clean cron...
[2021-06-08 00:33:32] [info]: 	Starting Cron...
[2021-06-08 00:33:32] [info]: 	Hassio API : Go !
[2021-06-08 00:33:42] [debug]: 	Nextcloud connection:  Success !
[2021-06-08 00:33:43] [debug]: 	Path /Hassio Backup/ already exist.
[2021-06-08 00:33:44] [info]: 	Nextcloud connection : Go !
[2021-06-08 00:34:03] [debug]: 	exclude_folder is not array (Empty value), reset...
[2021-06-08 00:34:03] [debug]: 	exclude_addon is not array (Empty value), reset...
[2021-06-08 00:34:03] [info]: 	Stopping Cron...
[2021-06-08 00:34:03] [info]: 	Starting Cron...
[2021-06-08 00:34:06] [info]: 	Stopping addons...
[2021-06-08 00:34:06] [info]: 	... Ok
[2021-06-08 00:34:06] [info]: 	Creating new snapshot...
[2021-06-08 00:39:16] [info]: 	Snapshot created with id 3a02a97c
[2021-06-08 00:39:16] [info]: 	Downloading snapshot 3a02a97c...
[2021-06-08 00:39:16] [debug]: 	Snapshot size: 159.12
[2021-06-08 00:39:19] [info]: 	Download success !
[2021-06-08 00:39:19] [debug]: 	Snapshot dl size : 159.12109375
[2021-06-08 00:39:19] [info]: 	Uploading snap...
[2021-06-08 00:39:19] [debug]: 	...URI: http://host.hiden/remote.php/webdav/Hassio%20Backup/Manual/Manual-2021.5.5-2021-06-08_0034.tar
[2021-06-08 00:39:26] [info]: 	Upload done...
[2021-06-08 00:39:29] [info]: 	...Upload finish ! (status: 201)
[2021-06-08 00:39:29] [info]: 	Starting addons...
[2021-06-08 00:39:29] [info]: 	... Ok
[2021-06-08 00:39:29] [debug]: 	Snapshot size: 80.51
[2021-06-08 00:39:29] [debug]: 	Snapshot size: 63.24
[2021-06-08 00:39:29] [info]: 	Local clean done.

That backup came back as "protected" = "false". Enabling and disabling the password and restarting the addon seems to have worked. So the bug maybe only occurs, when the addon is installed for the first time.

[Sebclem]

Hum very strange, I will take a look if nothing is wrong with the settings initialization

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Sebclem]

Nop, I still need to take a look at this 😅

[chanz]

<3
Since it works now, after I turned "Passwort Protection" on and off and restarting in between, I fear I can't be assisting you right now. But let me know how I can buy you a beer! :-)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[xxgmxx]

I am in a situation where I cannot restore backups because all of them are password-protected. I know that I got the password protection off but it wants me to put a password in while restoring. My HA is dead and all I have is password protected backups I cant restore :/ . Is it possible that the blank password put something in, like a default password?

[Sebclem]

Arfff, I don't understand this bug...

You can try with "null" or "undefined" but this bug is very strange.
I'm sorry if this doesn't work... I have reviewed all my code and I didn't find anything...

[xxgmxx]

I think that it kind of remembers the password, but shows like there is none. I just started a new VM to test it, and tried that again. When I checked the "password protected" and put the password there, saved and made a backup, then the backup is really protected by the password, but the addon shows that there is no password and even that the password protection is off. I did tried to protect my backups but it always unchecked the password protected to off, but seems like it actually works just do not show up correctly.