Comments (11)
Hi Jan, about documentation, I would also suggest to create one in German, maybe more people will use the software. Ebay Kleinanzeigen is only in Germany or lets say German speaking countries.
from kleinanzeigen-bot.
After reading a bit more about github wikis and PRs I think the best is we add a docs folder directly in the main repo and then maybe setup a CI job that publishes the contents from there as wiki pages.
This also has the advantage if a developer clones the repo the documentation is included too.
from kleinanzeigen-bot.
Hi Jan, I actually doubt a lot of users are using Debian as their desktop environment and the ones that do, are probably very tech saavy and can install 3.10 precompiled binaries from deadsnakes custom PPA as described here https://computingforgeeks.com/how-to-install-python-on-ubuntu-linux-system/ (or even easily compile Python from sources). We could however add instructions respective instructions to the readme.
Honestly I am not too keen to develop against an older Python version, as 3.10 brings some really nice language improvements that make it a joy to work with.
I am also planning to provide a docker image that has all the required/supported components (python, chromium, chrome driver). Which would be an even simpler way for Linux users to run the app.
WDYT?
from kleinanzeigen-bot.
Hi Seb,
personally, I'd never use a non-Debian repo, but then again - I'm also one of those that use Debian on my desktop - so perhaps I'm not a reference ;-)
Python 3.10 is from October 2021, so only 3 months old, which is very young for me. I like software similar to a steak - well hung / matured, so I prefer using older versions (that have a lots of bugs fixed) that are rock stable. But OTOH, I fully understand that you want to benefit from 3.10 improvements.
I'd say that for now, let's just document a workaround. If someday a lot of people request python <3.10 compat, we could still give it some thought.
That said, documentation is my thing and would like to contribute. Would you prefer documentation to be in the repo itself (subfolder?) or rather use github pages? Or - IMHO overkill at the moment - use a separate repo only for the docs?
I have used asciidoc and markdown/pandoc in other projects, but I think for now, some github wiki pages would be sufficient.
from kleinanzeigen-bot.
I think the wiki would be the best place for user documentation. However I don't know if you can actually send PRs to a wiki - even tho it is just a git repo. Not being able to send PRs would make contributions by non-project members difficult.
any experiences here?
from kleinanzeigen-bot.
any experiences here?
Some. I think you're right and there are no PRs possible. IIRC, you can either make the wiki public, or give project members edit permissions. If that's the case, I'd be happy to come up with something.
@Tschakk77
about documentation, I would also suggest to create one in German, maybe more people will use the software.
Yep, I'd initially go with a German version (German is my native language). We can always add more languages later.
from kleinanzeigen-bot.
Sounds good. I've no experience in github CI, does it require something special? If not, then we can just drop a couple of markdown files in a docs folder. I'd give them meaningful names and prefix them with a three-cipher-number, so one can also build a PDF with chapters from it, ex.:
010 - einleitung.md
020 - installation.md
030 - benutzung.md
040 - fehlersuche.md
xxx - entwicklung.md
yyy - mitarbeit.md
and so on...
from kleinanzeigen-bot.
Hi,
Debian stable only has python 3.9, with a dep on >= 3.10 we exclude a whole lot of users. Which part of the code depends on 3.10 and can we change that to work with 3.9?
I created a Dockerfile and some instructions to build an image. Would be great if you could give it a try.
https://github.com/kleinanzeigen-bot/kleinanzeigen-bot#installation-using-docker
from kleinanzeigen-bot.
Sounds good. I've no experience in github CI, does it require something special? If not, then we can just drop a couple of markdown files in a docs folder.
We can start by simply creating markdown files under a docs/
folder, e.g. like this:
docs/
de/
010 - einleitung.md
020 - installation.md
030 - benutzung.md
en/
010 - introduction.md
020 - installation.md
030 - usage.md
from kleinanzeigen-bot.
@jniggemann I am now also building self-contained executables for linux, maybe this solves your issue with not having python 3.10 available on debian https://github.com/kleinanzeigen-bot/kleinanzeigen-bot/releases/download/latest/kleinanzeigen-bot-linux-amd64
from kleinanzeigen-bot.
I am closing this as wontfix as now the option of using a docker image is available as well as the self-contained executables to run the bot.
from kleinanzeigen-bot.
Related Issues (20)
- Precompiled exe missing from last release HOT 4
- Sell directly false not working HOT 1
- ValueError: There is no such driver by url […] LATEST_RELEASE_116 HOT 8
- SSL: CERTIFICATE_VERIFY_FAILED HOT 8
- Chrome does not start, when a profil is used HOT 2
- @id='micro-frontend-price-type' or @id='priceType']' not found or not clickable; HOT 1
- Add easy multi-path in `config.yaml` via `ad_files` HOT 2
- No support for some article that have mandatory fields in `ad.yaml` HOT 1
- Web-element `buy-now-toggle` not found
- InvalidElementStateException: Message: invalid element state HOT 3
- Name is now readonly
- New anti-bot "feature" HOT 48
- Price type is not always available
- Feature: Reconnect on captcha when publishing
- Chromedriver not found HOT 3
- Another `SSL: CERTIFICATE_VERIFY_FAILED` HOT 1
- pdm install issue: module '_distutils_hack' has no attribute 'add_shim' HOT 1
- [BUG] ImportError: Can't connect to HTTPS URL because the SSL module is not available. HOT 22
- [BUG] negate direct buy only when shipping_type is SHIPPING
- [BUG] setting shipping options doesnt work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kleinanzeigen-bot.